search

jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Repo sync #43

Closed hello-smile6 closed 2 years ago

hello-smile6 commented 2 years ago

I have tested locally.

webdev03 commented 2 years ago

Hey, the actions workflow hasn't been tested and is in beta

hello-smile6 commented 2 years ago

Hey, the actions workflow hasn't been tested and is in beta

Then let's make it a draft PR.

jdev082 commented 2 years ago

what is "repo sync"

webdev03 commented 2 years ago

Adds the changes in hello-smile6 fork to this repository.

jdev082 commented 2 years ago

webload.html was renamed to index.html a while back

hello-smile6 commented 2 years ago

webload.html was renamed to index.html a while back

Okay, I'll fix that.

jdev082 commented 2 years ago

a check has failed. try running 'npm run check' in your code and run the formatter commands

jdev082 commented 2 years ago

please remove anything related to moving all the code to /, as I have already sorted out the problem.

jdev082 commented 2 years ago

all the changes of this PR have since already been applied, closing.

hello-smile6 commented 2 years ago

please remove anything related to moving all the code to /, as I have already sorted out the problem.

Okay, I merged that. There's no changes. I'll format it.

webdev03 commented 2 years ago

a check has failed. try running 'npm run check' in your code and run the formatter commands

It was because you didn't change the CI to fit changing the package.json, my PR does that.

hello-smile6 commented 2 years ago

all the changes of this PR have since already been applied, closing.

Actually, they have not. Look again.

jdev082 commented 2 years ago

this better not break anything...

jdev082 commented 2 years ago

conflicts...

webdev03 commented 2 years ago

Which conflicts are there? I can try to solve them...

jdev082 commented 2 years ago

app/package-lock.json app/package.json

webdev03 commented 2 years ago

app/package-lock.json app/package.json

I can't see them as I am not @hello-smile6 or @JaydenDev unfortunately.

jdev082 commented 2 years ago

i never gave hello-smile6 any special permissions...

webdev03 commented 2 years ago

@hello-smile6 made this PR.

webdev03 commented 2 years ago

Woohooo!

hello-smile6 commented 2 years ago

Fixed.

ninjamar commented 2 years ago

Can you add me into the contributors section? I just had a PR that got merged (#45 )

jdev082 commented 2 years ago

added you as a collaborator, accept the invite and see if that helps

hello-smile6 commented 2 years ago

I'll fix it!

webdev03 commented 2 years ago

Checks failed! Checks failed! Please check the Actions workflow!!!!!

ninjamar commented 2 years ago

added you as a collaborator, accept the invite and see if that helps

i don't see an invite