search

jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Make freecat easier to work with #44

Closed webdev03 closed 2 years ago

webdev03 commented 2 years ago

Normally, in projects, we can do npm install first on the directory we cloned, but in Freecat, we have to cd into the app folder first. I don't think this is a monorepo so I think that it would be fine if the npm scripts pointed to app.

webdev03 commented 2 years ago

I can try to do this after the Prettier PR gets merged.

hello-smile6 commented 2 years ago

I can try to do this after the Prettier PR gets merged.

I'll see if I could make passthrough binaries for different platforms in the root directory.

webdev03 commented 2 years ago

I can try to do this after the Prettier PR gets merged.

I'll see if I could make passthrough binaries for different platforms in the root directory.

?

hello-smile6 commented 2 years ago

I can try to do this after the Prettier PR gets merged.

I'll see if I could make passthrough binaries for different platforms in the root directory.

?

npm binaries that cd into app/ and run npm.

jdev082 commented 2 years ago

binaries dont go in the repository, only in releases.

webdev03 commented 2 years ago

I mean to say, then you can run npm install and npm run start in the directory you cloned without CD into the app/ directory. I got this idea because of the CI I was making for Freecat.

jdev082 commented 2 years ago

The app is in app/, repository information, licensing, and run scripts go in /

webdev03 commented 2 years ago

The thing is that Prettier is a dev dependency just like Electron and the others (excluding electron-forge I think) so that wouldn't be possible without #44

webdev03 commented 2 years ago

Okay, I've managed to do this, @JaydenDev should I PR? Now Prettier can run on the MD files if you want.

hello-smile6 commented 2 years ago

Okay, I've managed to do this, @JaydenDev should I PR? Now Prettier can run on the MD files if you want.

Go for it!

webdev03 commented 2 years ago

@JaydenDev close this because you closed #47

hello-smile6 commented 2 years ago

@JaydenDev close this because you closed #47

Please don't close this.

jdev082 commented 2 years ago

done.

webdev03 commented 2 years ago

By the way, your version of my changes just broke Freecat, change the "main" package.json to point to the right file.

webdev03 commented 2 years ago

Also, the CI is broken too. Please fix that.

hello-smile6 commented 2 years ago

Also, the CI is broken too. Please fix that.

Run git pull