search

jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Better installation instructions #45

Closed ninjamar closed 2 years ago

ninjamar commented 2 years ago

I added better installation instructions because there doesn't need to be a separate file for every platform. 2 lines of shell script doesn't need its own file.

webdev03 commented 2 years ago

fakecommit can just be an empty git commit probably with git commit --allow-empty. I hope this gets merged. Also run-mac.sh does nothing

ninjamar commented 2 years ago

fakecommit can just be an empty git commit probably with git commit --allow-empty. I hope this gets merged. Also run-mac.sh does nothing

It shouldn't be based on platform, it should be based by shell.

webdev03 commented 2 years ago

fakecommit can just be an empty git commit probably with git commit --allow-empty. I hope this gets merged. Also run-mac.sh does nothing

It shouldn't be based on platform, it should be based by shell.

Those scripts also have no reason to exist

ninjamar commented 2 years ago

fakecommit can just be an empty git commit probably with git commit --allow-empty. I hope this gets merged. Also run-mac.sh does nothing

It shouldn't be based on platform, it should be based by shell.

Those scripts also have no reason to exist

Yep

jdev082 commented 2 years ago

run-mac.sh doesn't have code in it since I don't know the utilities available in MacOS.

webdev03 commented 2 years ago

It's the exact same as Linux, and anyways - there is no point of that, it is easy to say "just install dependencies and then npm run start to start developing"

jdev082 commented 2 years ago

in MacOS since npm isn't installed via a package manager, I cant guarantee NPM is in the PATH

webdev03 commented 2 years ago

NPM is installed either by downloading it through the node website (which should be in path already) or through a package manager like homebrew or through a version manager like NVM which also installs NPM.

jdev082 commented 2 years ago

to make fc easier for new users the scripts are there

webdev03 commented 2 years ago

But then if they know how to run those scripts they should be able to run 2 lines in the terminal?

jdev082 commented 2 years ago

What's standard for my applications is a setup.bin, acting similarly to a Windows installer. Using a Unix/Linux utility called: dialogue to create TUI menus for a proper installer. However, what's the point. We have packages, if you are a new user and cant code, install a package. The constant channel is for developers. Merging PR

hello-smile6 commented 2 years ago

What's standard for my applications is a setup.bin, acting similarly to a Windows installer. Using a Unix/Linux utility called: dialogue to create TUI menus for a proper installer. However, what's the point. We have packages, if you are a new user and cant code, install a package. The constant channel is for developers. Merging PR

I'll work on this. We need to allow everyone.