jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Fix Freecat, like literally please fix it #48

Closed webdev03 closed 2 years ago

webdev03 commented 2 years ago

You can't run Freecat anymore since when making https://github.com/JaydenDev/freecat/commit/3e31ddac766919fd9d685065027883b31fdfbd02 the "main" in package.json hasn't been changed to fit this which has broken Freecat. I have a new idea: Test your commits before pushing them to main branch or staging.

jdev082 commented 2 years ago

the issue has to do with me forgetting to change main/main.js to app/main/main.js, fixing

webdev03 commented 2 years ago

OK! Can you also merge my PR which puts the Prettier files in the root directory to make Prettier work?

webdev03 commented 2 years ago

Also, the CI is broken - you'll need to fix that

jdev082 commented 2 years ago

there are no PRs available rn Idk what CI is

webdev03 commented 2 years ago

CI is the Github actions. My PR that you closed actually did this correctly.

webdev03 commented 2 years ago

For reference, #47 is the PR that is closed.

jdev082 commented 2 years ago

It seemed like a risky PR, what changes did you make exactly. What is the CI for? What does it do? If it forces people to use a utility im removing it

webdev03 commented 2 years ago

No, it's the Github actions that checks if they run the Prettier, it doesn't force anything it's just to help you. You can see the exact changes I made https://github.com/JaydenDev/freecat/pull/47/commits/8cbce2b8da80afb023f502d818d8ecb2aec14ffd

hello-smile6 commented 2 years ago

It seemed like a risky PR, what changes did you make exactly. What is the CI for? What does it do? If it forces people to use a utility im removing it

It helps make sure that the code is understandable and helps avoid broken commits. It's not required, but I'd encourage it, as it'd also catch failed merges.

jdev082 commented 2 years ago

I will have to revert freecat to a working build, a PR must of broke it.

jdev082 commented 2 years ago

I dont know why it doesn't run, so I cant fix it.

webdev03 commented 2 years ago

Your commit broke it!!! Edit; it's fixed now, you reverted that, sorry

hello-smile6 commented 2 years ago

I will have to revert freecat to a working build, a PR must of broke it.

Revert whatever you just did. My fork has a working configuration. I have an open PR (#43) that will fix it.