search

jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

removed builds + added me as a contributor #59

Closed ninjamar closed 2 years ago

ninjamar commented 2 years ago

removed builds + added me as a contributor

sorry for spamming prs solution : give me edit access

webdev03 commented 2 years ago

By the way, can you format with prettier? Or I can do it for you.

ninjamar commented 2 years ago

By the way, can you format with prettier? Or I can do it for you.

How do I do that?

webdev03 commented 2 years ago

I can do it.

webdev03 commented 2 years ago

(it was literally a space, but whatever)

ninjamar commented 2 years ago

(it was literally a space, but whatever)

ok can you merge?

hello-smile6 commented 2 years ago

(it was literally a space, but whatever)

ok can you merge?

Not yet, I want to review everything.

webdev03 commented 2 years ago

Hey, this can get merged, but this might work out better...

ninjamar commented 2 years ago

someone added some , inside the file. can we remove them?

hello-smile6 commented 2 years ago

I agree, let's go with that.

hello-smile6 commented 2 years ago

someone added some , inside the file. can we remove them?

Where? Link to the line.

ninjamar commented 2 years ago

https://github.com/JaydenDev/freecat/pull/59/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R39 it should be "Better readme, random stuff and issues"

jdev082 commented 2 years ago

dont give him edit access, only I can do that

jdev082 commented 2 years ago

only the 2 current collaborators can have collaborator status, everyone else dont be lazy and make darn PRs.

jdev082 commented 2 years ago

you do NOT use HTML in MARKDOWN you CANT and SHOULDNT

Closing

hello-smile6 commented 2 years ago

you do NOT use HTML in MARKDOWN you CANT and SHOULDNT

Closing

You can use HTML in markdown, though.

webdev03 commented 2 years ago

You can!! How else to add images? And it was already there in the start!

jdev082 commented 2 years ago

You CAN, I just hate it.

ninjamar commented 2 years ago

I just removed the html. Why did you close? Also everyone stop yelling.

webdev03 commented 2 years ago

Okay, sorry all, I think we now have a workflow that can add in the contributors for us :)

ninjamar commented 2 years ago

Okay, sorry all, I think we now have a workflow that can add in the contributors for us :)

Ok. Why does @JaydenDev keep closing my issues and pr's?

hello-smile6 commented 2 years ago

Okay, sorry all, I think we now have a workflow that can add in the contributors for us :)

Ok. Why does @JaydenDev keep closing my issues and pr's?

I think they just don't want help. Feel free to contribute to my fork.

ninjamar commented 2 years ago

Okay, sorry all, I think we now have a workflow that can add in the contributors for us :)

Ok. Why does @JaydenDev keep closing my issues and pr's?

I think they just don't want help. Feel free to contribute to my fork.

Sure

webdev03 commented 2 years ago

Yeah, I'm going on your fork now.