search

jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Add icon #60

Closed hello-smile6 closed 2 years ago

hello-smile6 commented 2 years ago

Let's get this icon in! Merge subsequent PRs and commits into the add-icon branch. Don't merge until this works.

Support

webdev03 commented 2 years ago

Since we may be accepting PRs for this, I thought it might be good to label.

hello-smile6 commented 2 years ago

Since we may be accepting PRs for this, I thought it might be good to label.

Good idea, let's merge everything related to the icon into the add-icon branch.

webdev03 commented 2 years ago

I'm working on getting it with Electron Forge. I'll add the file we're working on to make an icon, but which file are we using?

jdev082 commented 2 years ago

k

webdev03 commented 2 years ago

@JaydenDev which file? seconds.svg right?

webdev03 commented 2 years ago

or the "big F"?

jdev082 commented 2 years ago

seconds.svg at 32x32 sizse

webdev03 commented 2 years ago

OK....

jdev082 commented 2 years ago

you both have been removed from collaborators for abuse of permissions, and lacking of asking for permission. Its much safer if I have control of the flow and merging of PRs, so I can monitor and deny bad edits

webdev03 commented 2 years ago

How did we abuse it? Sorry, but I worked hard. I don't want the logo to be used now.

hello-smile6 commented 2 years ago

you both have been removed from collaborators for abuse of permissions, and lacking of asking for permission. Its much safer if I have control of the flow and merging of PRs, so I can monitor and deny bad edits

Sorry.

hello-smile6 commented 2 years ago

How did we abuse it? Sorry, but I worked hard. I don't want the logo to be used now.

That might be hard, since you can't remove it.

jdev082 commented 2 years ago

you made unwanted changes to the README you almost accepted a concerning PR really? seriously?

webdev03 commented 2 years ago

I did not accept it, I was waiting for you to give your permission, sorry. Unwanted changes? I thought we are working on this branch.

jdev082 commented 2 years ago

Top contributors!? we dont do that here.

hello-smile6 commented 2 years ago

you made unwanted changes to the README you almost accepted a concerning PR really? seriously?

Sorry, my display's only so big. And at the time when I said that it looked good, the readme hadn't been updated. I re-added the build link on theirs.

hello-smile6 commented 2 years ago

Top contributors!? we dont do that here.

It was either that or remove the contributor descriptions. The workflow would've done that. Sorry.

jdev082 commented 2 years ago

re-added, learn from mistakes.

hello-smile6 commented 2 years ago

re-added, learn from mistakes.

Sorry.

jdev082 commented 2 years ago

icons are complicated

hello-smile6 commented 2 years ago

I agree.

webdev03 commented 2 years ago

npm run format

hello-smile6 commented 2 years ago

icons are complicated

Is it okay if I push a change that will get part of the way to having a Windows icon to the add-icon branch?

webdev03 commented 2 years ago

Just a request if you can remove my logo and make a better one, mine was designed for macOS from the start.

hello-smile6 commented 2 years ago

Just a request if you can remove my logo and make a better one, mine was designed for macOS from the start.

I'll remove your logo from every commit. Okay?

hello-smile6 commented 2 years ago

Just a request if you can remove my logo and make a better one, mine was designed for macOS from the start.

I'll remove your logo from every commit. Okay?

Never mind, but removing it from all branches.

hello-smile6 commented 2 years ago

@JaydenDev You said you wanted to merge this into main. If you still want to, it's ready.

jdev082 commented 2 years ago

Doesn't work on Linux

hello-smile6 commented 2 years ago

Doesn't work on Linux

Doesn't work on Windows, but you wanted to merge.