jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

global install file #69

Closed ScolderCreations closed 2 years ago

ScolderCreations commented 2 years ago

this file prepares dependencies and opens the app. works on all major OSes, I think. Shouldn’t be too hard to test, just clone and run the shell script.

FunctionalMetatable commented 2 years ago

Windows? you should add batch as well

jdev082 commented 2 years ago

its really not needed, they can just run those 3 commands.

jdev082 commented 2 years ago

run 'npm run format', then I might consider it.

webdev03 commented 2 years ago

it is eslint, and also by the way who put eslint here? i didnt add my pr in

webdev03 commented 2 years ago

error Expected '===' and instead saw '==' eqeqeq

jdev082 commented 2 years ago

do we even need this PR? community, decide.

hello-smile6 commented 2 years ago

do we even need this PR? community, decide.

I vote yes.

jdev082 commented 2 years ago

We don't need any useless bloat install scripts, when you git clone you are expected to be a developer. If you aren't a developer, grab a packaged build. EXE(s) will be provided for 1.1 along side linux packages.

hello-smile6 commented 2 years ago

We don't need any useless bloat install scripts, when you git clone you are expected to be a developer. If you aren't a developer, grab a packaged build. EXE(s) will be provided for 1.1 along side linux packages.

It's not useless or bloat. Remember what you thought about using prettier? Remember when you didn't want to use addEventListener? This is a good idea!

ScolderCreations commented 2 years ago

We don't need any useless bloat install scripts, when you git clone you are expected to be a developer. If you aren't a developer, grab a packaged build. EXE(s) will be provided for 1.1 along side linux packages.

This isn’t bloat, it’s just a time-saver.

If you don’t re-open this, don’t worry, I can make a new PR. There isn’t a reason not to have this, and there is a reason to have this, so I don’t get why you don’t want this. It’s entirely possible you just hate my code in general, but that isn’t very fair.

hello-smile6 commented 2 years ago

We don't need any useless bloat install scripts, when you git clone you are expected to be a developer. If you aren't a developer, grab a packaged build. EXE(s) will be provided for 1.1 along side linux packages.

This isn’t bloat, it’s just a time-saver.

If you don’t re-open this, don’t worry, I can make a new PR. There isn’t a reason not to have this, and there is a reason to have this, so I don’t get why you don’t want this. It’s entirely possible you just hate my code in general, but that isn’t very fair.

I'll reopen. Also, make the PR on my repo, so I can accidentally merge it the next time I sync my fork.

hello-smile6 commented 2 years ago

Reopening. Please actually consider this this time.

jdev082 commented 2 years ago

A time saver for 2 commands, lmao just type them yourself.

hello-smile6 commented 2 years ago

A time saver for 2 commands, lmao just type them yourself.

WHY? It's important!

jdev082 commented 2 years ago

maybe npm run setup which runs

npm install
npm start

and

npm run linux64-install

which runs

echo Installing...
echo "This script doesn't install native binary."
mkdir -p ~/.local/freecat
cp -r * ~/.local/freecat/
cat "npm start" >> freecat.bin
chmod +x freecat.bin
DIR=$(pwd)
ln -sf $DIR/freecat.bin ~/.local/bin/freecat
hello-smile6 commented 2 years ago

maybe npm run setup which runs

npm install
npm start

and

npm run linux64-install

which runs

echo Installing...
echo This script doesn't install native binary.
mkdir -p ~/.local/freecat
cp -r * ~/.local/freecat/
cat "npm start" >> freecat.bin
chmod +x freecat.bin
DIR=$(pwd)
ln -sf $DIR/freecat.bin ~/.local/bin/freecat

Huh.

jdev082 commented 2 years ago

I used rather advanced bash programming...

pwd finds the current directory cp copies files chmod +x marks a file as an executable mkdir makes a directory. ln makes a symlink

jdev082 commented 2 years ago

btw look at the PR number

hello-smile6 commented 2 years ago

btw look at the PR number

So?

jdev082 commented 2 years ago

I don't know how to edit package.json, so could you add my script under the respective commands?

hello-smile6 commented 2 years ago

I don't know how to edit package.json, so could you add my script under the respective commands?

Sure.

hello-smile6 commented 2 years ago

maybe npm run setup which runs

npm install
npm start

and

npm run linux64-install

which runs

echo Installing...
echo "This script doesn't install native binary."
mkdir -p ~/.local/freecat
cp -r * ~/.local/freecat/
cat "npm start" >> freecat.bin
chmod +x freecat.bin
DIR=$(pwd)
ln -sf $DIR/freecat.bin ~/.local/bin/freecat

@JaydenDev I noticed that your echo command needed quotation marks.

jdev082 commented 2 years ago
npm run linux64-run
npm run linux64-install
npm run deb64-make
npm run rpm64-make

I wanna have this kinda thing, so you don't end up having to make binaries for other platforms.

hello-smile6 commented 2 years ago
npm run linux64-run
npm run linux64-install
npm run deb64-make
npm run rpm64-make

I wanna have this kinda thing, so you don't end up having to make binaries for other platforms.

That'd probably be easy. Just make it have individual scripts for each target and run all of them in the make script.

jdev082 commented 2 years ago
npm run linux64-run
npm run linux64-install
npm run deb64-make
npm run rpm64-make

I wanna have this kinda thing, so you don't end up having to make binaries for other platforms.

That'd probably be easy. Just make it have individual scripts for each target and run all of them in the make script.

no.. no. the point of the individual scripts is to NOT build unnecessary binaries.

hello-smile6 commented 2 years ago
npm run linux64-run
npm run linux64-install
npm run deb64-make
npm run rpm64-make

I wanna have this kinda thing, so you don't end up having to make binaries for other platforms.

That'd probably be easy. Just make it have individual scripts for each target and run all of them in the make script.

no.. no. the point of the individual scripts is to NOT build unnecessary binaries.

Yes, you could then use the per-platform build scripts normally, but use the others when you have to build for a github release.