Closed ScolderCreations closed 2 years ago
Windows? you should add batch as well
its really not needed, they can just run those 3 commands.
run 'npm run format', then I might consider it.
it is eslint, and also by the way who put eslint here? i didnt add my pr in
error Expected '===' and instead saw '==' eqeqeq
do we even need this PR? community, decide.
do we even need this PR? community, decide.
I vote yes.
We don't need any useless bloat install scripts, when you git clone you are expected to be a developer. If you aren't a developer, grab a packaged build. EXE(s) will be provided for 1.1 along side linux packages.
We don't need any useless bloat install scripts, when you git clone you are expected to be a developer. If you aren't a developer, grab a packaged build. EXE(s) will be provided for 1.1 along side linux packages.
It's not useless or bloat. Remember what you thought about using prettier? Remember when you didn't want to use addEventListener
? This is a good idea!
We don't need any useless bloat install scripts, when you git clone you are expected to be a developer. If you aren't a developer, grab a packaged build. EXE(s) will be provided for 1.1 along side linux packages.
This isn’t bloat, it’s just a time-saver.
If you don’t re-open this, don’t worry, I can make a new PR. There isn’t a reason not to have this, and there is a reason to have this, so I don’t get why you don’t want this. It’s entirely possible you just hate my code in general, but that isn’t very fair.
We don't need any useless bloat install scripts, when you git clone you are expected to be a developer. If you aren't a developer, grab a packaged build. EXE(s) will be provided for 1.1 along side linux packages.
This isn’t bloat, it’s just a time-saver.
If you don’t re-open this, don’t worry, I can make a new PR. There isn’t a reason not to have this, and there is a reason to have this, so I don’t get why you don’t want this. It’s entirely possible you just hate my code in general, but that isn’t very fair.
I'll reopen. Also, make the PR on my repo, so I can accidentally merge it the next time I sync my fork.
Reopening. Please actually consider this this time.
A time saver for 2 commands, lmao just type them yourself.
A time saver for 2 commands, lmao just type them yourself.
WHY? It's important!
maybe npm run setup
which runs
npm install
npm start
and
npm run linux64-install
which runs
echo Installing...
echo "This script doesn't install native binary."
mkdir -p ~/.local/freecat
cp -r * ~/.local/freecat/
cat "npm start" >> freecat.bin
chmod +x freecat.bin
DIR=$(pwd)
ln -sf $DIR/freecat.bin ~/.local/bin/freecat
maybe
npm run setup
which runsnpm install npm start
and
npm run linux64-install
which runs
echo Installing... echo This script doesn't install native binary. mkdir -p ~/.local/freecat cp -r * ~/.local/freecat/ cat "npm start" >> freecat.bin chmod +x freecat.bin DIR=$(pwd) ln -sf $DIR/freecat.bin ~/.local/bin/freecat
Huh.
I used rather advanced bash programming...
pwd
finds the current directory
cp
copies files
chmod +x
marks a file as an executable
mkdir
makes a directory.
ln
makes a symlink
btw look at the PR number
btw look at the PR number
So?
I don't know how to edit package.json
, so could you add my script under the respective commands?
I don't know how to edit
package.json
, so could you add my script under the respective commands?
Sure.
maybe
npm run setup
which runsnpm install npm start
and
npm run linux64-install
which runs
echo Installing... echo "This script doesn't install native binary." mkdir -p ~/.local/freecat cp -r * ~/.local/freecat/ cat "npm start" >> freecat.bin chmod +x freecat.bin DIR=$(pwd) ln -sf $DIR/freecat.bin ~/.local/bin/freecat
@JaydenDev I noticed that your echo
command needed quotation marks.
npm run linux64-run
npm run linux64-install
npm run deb64-make
npm run rpm64-make
I wanna have this kinda thing, so you don't end up having to make binaries for other platforms.
npm run linux64-run npm run linux64-install npm run deb64-make npm run rpm64-make
I wanna have this kinda thing, so you don't end up having to make binaries for other platforms.
That'd probably be easy. Just make it have individual scripts for each target and run all of them in the make
script.
npm run linux64-run npm run linux64-install npm run deb64-make npm run rpm64-make
I wanna have this kinda thing, so you don't end up having to make binaries for other platforms.
That'd probably be easy. Just make it have individual scripts for each target and run all of them in the
make
script.
no.. no. the point of the individual scripts is to NOT build unnecessary binaries.
npm run linux64-run npm run linux64-install npm run deb64-make npm run rpm64-make
I wanna have this kinda thing, so you don't end up having to make binaries for other platforms.
That'd probably be easy. Just make it have individual scripts for each target and run all of them in the
make
script.no.. no. the point of the individual scripts is to NOT build unnecessary binaries.
Yes, you could then use the per-platform build scripts normally, but use the others when you have to build for a github release.
this file prepares dependencies and opens the app. works on all major OSes, I think. Shouldn’t be too hard to test, just clone and run the shell script.