jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Binaries don't work #70

Closed hello-smile6 closed 2 years ago

hello-smile6 commented 2 years ago

Command-line output:

C:\Users\hello-smile6\Documents\GitHub\freecat>npm run make

> freecat@1.0.0 make
> electron-forge make

✔ Checking your system
✔ Resolving Forge Config
We need to package your application before we can make it
✔ Preparing to Package Application for arch: x64
✔ Preparing native dependencies
✔ Packaging Application
Making for the following targets: squirrel
✔ Making for target: squirrel - On platform: win32 - For arch: x64

OS and dependency versions:

Windows:

Microsoft Windows [Version 10.0.19042.985]

Node:

v16.13.1

NPM:

8.1.2

Other information

Screenshot

screenshot

hello-smile6 commented 2 years ago

@JaydenDev Side comment: I have to say that this template's helpful. It took me less time then it would've normally to create this issue.

jdev082 commented 2 years ago

It's a known issue that EXE binaries dont work properly, in fact none of them do. They all have the same error, deb64 rpm64 and win64

hello-smile6 commented 2 years ago

It's a known issue that EXE binaries dont work properly, in fact none of them do. They all have the same error, deb64 rpm64 and win64

I'll try to fix it.

jdev082 commented 2 years ago

you'll have to fix it for Win/Mac/Linux

hello-smile6 commented 2 years ago

you'll have to fix it for Win/Mac/Linux

If I'm right, it'll take less than 30 seconds.

hello-smile6 commented 2 years ago

Well, I was right. Unfortunately, I introduced another bug. I'll fix that, then we'll finally have some binaries!

hello-smile6 commented 2 years ago

@JaydenDev Told you!

jdev082 commented 2 years ago

70 and #71 are related in ways, dont close any tho

hello-smile6 commented 2 years ago

Testing.

jdev082 commented 2 years ago
TypeError [ERR_INVALID_ARG_TYPE]: The "listener" argument must be of type function. Received undefined
    at checkListener (node:events:131:3)
    at _addListener (node:events:427:3)
    at App.addListener (node:events:491:10)
    at Object.<anonymous> (/home/jmwills/GitHub/freecat/main/main.js:73:5)
    at Module._compile (node:internal/modules/cjs/loader:1116:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1169:10)
    at Module.load (node:internal/modules/cjs/loader:988:32)
    at Module._load (node:internal/modules/cjs/loader:829:12)
    at Function.c._load (node:electron/js2c/asar_bundle:5:13331)
    at loadApplicationPackage (/usr/local/lib/node_modules/electron/dist/resources/default_app.asar/main.js:110:16)
A JavaScript error occurred in the main process
Uncaught Exception:
TypeError [ERR_INVALID_ARG_TYPE]: The "listener" argument must be of type function. Received undefined
    at checkListener (node:events:131:3)
    at _addListener (node:events:427:3)
    at App.addListener (node:events:491:10)
    at Object.<anonymous> (/home/jmwills/GitHub/freecat/main/main.js:73:5)
    at Module._compile (node:internal/modules/cjs/loader:1116:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1169:10)
    at Module.load (node:internal/modules/cjs/loader:988:32)
    at Module._load (node:internal/modules/cjs/loader:829:12)
    at Function.c._load (node:electron/js2c/asar_bundle:5:13331)
    at loadApplicationPackage (/usr/local/lib/node_modules/electron/dist/resources/default_app.asar/main.js:110:16)

Caused by: https://github.com/JaydenDev/freecat/blob/main/main/main.js#L73

jdev082 commented 2 years ago
__   __                  _                      _             _   _         
\ \ / /   ___    _   _  | |__    _ __    ___   | | __   ___  (_) | |_       
 \ V /   / _ \  | | | | | '_ \  | '__|  / _ \  | |/ /  / _ \ | | | __|      
  | |   | (_) | | |_| | | |_) | | |    | (_) | |   <  |  __/ | | | |_ _ _ _ 
  |_|    \___/   \__,_| |_.__/  |_|     \___/  |_|\_\  \___| |_|  \__(_|_|_)
hello-smile6 commented 2 years ago
__   __                  _                      _             _   _         
\ \ / /   ___    _   _  | |__    _ __    ___   | | __   ___  (_) | |_       
 \ V /   / _ \  | | | | | '_ \  | '__|  / _ \  | |/ /  / _ \ | | | __|      
  | |   | (_) | | |_| | | |_) | | |    | (_) | |   <  |  __/ | | | |_ _ _ _ 
  |_|    \___/   \__,_| |_.__/  |_|     \___/  |_|\_\  \___| |_|  \__(_|_|_)

Run this:

sudo npm i -g node@latest npm@latest npx@latest
sudo apt update
npm update

Does it still happen? It works for me.

jdev082 commented 2 years ago

gotta w o r k

on

L i n u x

hello-smile6 commented 2 years ago

gotta w o r k

on

L i n u x

gotta u p d a t e

y o u r O S

See if that works. Also, try doing git pull again.

jdev082 commented 2 years ago

You are not cooperating like a good collaborator would. Just because it works for you, that's not an excuse to not fix it on other systems :( Might as well revert all your commits that broke freecat :(

hello-smile6 commented 2 years ago

You are not cooperating like a good collaborator would. Just because it works for you, that's not an excuse to not fix it on other systems :(

Never mind, didn't work for me. I fixed it, there was a problem with it because I forgot to rewrite something.

hello-smile6 commented 2 years ago

@JaydenDev Figured it out, about to merge once I test.

hello-smile6 commented 2 years ago

Fixed by https://github.com/JaydenDev/freecat/commit/98c4542f61e6274cf9aae5124b02f042e498c341, let's celebrate!