search

jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Finish fixing up-to-date version #92

Closed hello-smile6 closed 2 years ago

hello-smile6 commented 2 years ago

Continuing #91 . I think I got everything, and I managed to build successfully.

jdev082 commented 2 years ago

pr 91 already fixed everything your PR will break things

jdev082 commented 2 years ago

duplicate PR that does things that have already been done. useless.

hello-smile6 commented 2 years ago

duplicate PR that does things that have already been done. useless.

No, I didn't finish on #91. You merged it before I could finish. #91 leaved it in a partially fixed state.

jdev082 commented 2 years ago

reopened for inspection btw u already fixed it no need to do an unneeded fix sir

jdev082 commented 2 years ago

its going into testing branch so ill accept it

hello-smile6 commented 2 years ago

@JaydenDev I wasn't expecting you to merge it then. I didn't have time to finish. Also, I successfully built win32 binaries, you should be able to run them using wine. https://instant.io/#c376dc9a9e8d869f3a4be999071f5e7433901aba

hello-smile6 commented 2 years ago

reopened for inspection btw u already fixed it no need to do an unneeded fix sir

I had fixed it, but didn't run git commit until after you merged.

hello-smile6 commented 2 years ago

Does it work for you?

hello-smile6 commented 2 years ago

@JaydenDev Does it work for you? Including releases?

kccuber-scratch commented 2 years ago

what the heck? why is it half under the GPL and half MIT? @JaydenDev dont tell me you merged PRs without looking again

hello-smile6 commented 2 years ago

what the heck? why is it half under the GPL and half MIT? @JaydenDev dont tell me you merged PRs without looking again

They're not merging without looking, obviously.