jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

2.0 features #94

Closed jdev082 closed 2 years ago

jdev082 commented 2 years ago

New UI, dream.css implementation Bug Fixes

tabs pls :) help tabs idk how to tab tabs

jdev082 commented 2 years ago

testing issue comments with gh cli

hello-smile6 commented 2 years ago

@JaydenDev I got tabs, I think.

jdev082 commented 2 years ago

ok

hello-smile6 commented 2 years ago

ok

I just learned how to make a GitHub workspace file for a configuration, should I commit it?

jdev082 commented 2 years ago

what exactly is a workspace, is it needed?

hello-smile6 commented 2 years ago

what exactly is a workspace, is it needed?

It just adds a JSON file like this which tells VSCode how to set up the editor environment.

{
    "folders": [
        {
            "path": "."
        }
    ],
    "settings": {}
}

Then, everyone'd have the same vscode configuration.

jdev082 commented 2 years ago

thats useless when they can just import the folder

or use vim :)

hello-smile6 commented 2 years ago

thats useless when they can just import the folder

or use vim :)

I'm just going to say it, vim is junk. It's nearly impossible to close. Also, there might be a specific configuration you want people to use someday. That'd allow you to set things like that.

hello-smile6 commented 2 years ago

Are you going to merge the testing branch into main?

jdev082 commented 2 years ago

what do you expect? its a CLI text editor if you cant even CLI then dont use it. Its easy :w to write :q to close omg is it that hard?

jdev082 commented 2 years ago

testing branch goes through excessive testing before going into main to be packaged as a dev build

hello-smile6 commented 2 years ago

what do you expect? its a CLI text editor if you cant even CLI then dont use it. Its easy :w to write :q to close omg is it that hard?

Wait, :w to write? Also, nano's easier.

hello-smile6 commented 2 years ago

testing branch goes through excessive testing before going into main to be packaged as a dev build

But it works! Try it!

jdev082 commented 2 years ago

i have to go, i'll take a look at it tomarrow

hello-smile6 commented 2 years ago

i have to go, i'll take a look at it tomarrow

Okay.

hello-smile6 commented 2 years ago

New UI, dream.css implementation Bug Fixes

tabs pls :) help tabs idk how to tab tabs

Think it's ironic that Freecat's using @MystPi's CSS library, while still not having the same UI as their electron browser.

jdev082 commented 2 years ago

i dont remember who added the css library. I have half-decent UI design, and that's really an overstatement.

hello-smile6 commented 2 years ago

i dont remember who added the css library. I have half-decent UI design, and that's really an overstatement.

It was me, in case you're wondering. Isn't their stylesheet pretty?

jdev082 commented 2 years ago

I CAN make modern UI design in fact FreeCat already HAD modern UI design.

hello-smile6 commented 2 years ago

I CAN make modern UI design in fact FreeCat already HAD modern UI design.

I agree. Also, why not just use the URL change code from Ninetails to update the URL shown? I noticed that they have that done.

jdev082 commented 2 years ago

since the URL bar is a literal tag that isn't possible. unless the website src the webview is set to can be used to change the text in the input bar.. OH MY GOD it is

Find a way to set the text of the URL bar to whatever the webview src is set to

hello-smile6 commented 2 years ago

since the URL bar is a literal tag that isn't possible. unless the website src the webview is set to can be used to change the text in the input bar.. OH MY GOD it is

Find a way to set the text of the URL bar to whatever the webview src is set to

Simple. Check out https://github.com/MystPi/ninetails/blob/b7ee7b7a518cafa76822437f259841a39f3932fc/src/browser.js#L208

jdev082 commented 2 years ago

the UI is made in HTML not javascript

hello-smile6 commented 2 years ago

the UI is made in HTML not javascript

That's how you run code every time the page URL in the webview changes.

jdev082 commented 2 years ago

this is purely an aesthetic feature I need FreeCat to not be a dumpster fire first

hello-smile6 commented 2 years ago

this is purely an aesthetic feature I need FreeCat to not be a dumpster fire first

What do you mean? Also, I got it. Making a PR.

jdev082 commented 2 years ago

FreeCat and its code is an unstable feature-lacking dumpster fire Even Ninetails (a kinda direct competitor) has more features and its been around for a shorter amount of time

jdev082 commented 2 years ago

the "random browser made by a scratcher" market is a race to the finish.

hello-smile6 commented 2 years ago

FreeCat and its code is an unstable feature-lacking dumpster fire Even Ninetails (a kinda direct competitor) has more features and its been around for a shorter amount of time

Well, most of the Ninetails features could be added in under 2 hours. Also, does the testing branch work?

hello-smile6 commented 2 years ago

Never mind.

hello-smile6 commented 2 years ago

Also, it works. We have dynamic URL updating.

jdev082 commented 2 years ago

ima merge it to testing

hello-smile6 commented 2 years ago

Testing it to make sure it works well.

jdev082 commented 2 years ago

ok

hello-smile6 commented 2 years ago

Haven't made a commit yet.

jdev082 commented 2 years ago

ok

if you use FreeCat, you understand the dumpster fire

hello-smile6 commented 2 years ago

ok

if you use FreeCat, you understand the dumpster fire

I know what you mean. Also, I got a video of the URL bar update feature.

https://user-images.githubusercontent.com/73048226/146273106-23b4adc2-b711-48c1-a2cd-82f6a0eb9a5a.mp4

jdev082 commented 2 years ago

No video with supported format and MIME type found

hello-smile6 commented 2 years ago

No video with supported format and MIME type found

What? Do you not have an MP4 codec?

jdev082 commented 2 years ago

i might not im on linux after all i think its a GH issue

hello-smile6 commented 2 years ago

i might not im on linux after all i think its a GH issue

Try downloading and running it using bash, that should open a video player which can play it. https://user-images.githubusercontent.com/73048226/146273106-23b4adc2-b711-48c1-a2cd-82f6a0eb9a5a.mp4

hello-smile6 commented 2 years ago

See #97

jdev082 commented 2 years ago

I installed all the codecs and libraries needed and it still doesn't show

hello-smile6 commented 2 years ago

I installed all the codecs and libraries needed and it still doesn't show

Try downloading a Chromium build from https://download-chromium.appspot.com/ or installing chromium-browser using your package manager, Chromium might work.

jdev082 commented 2 years ago

no #firefoxftw

jdev082 commented 2 years ago

btw i can just run sudo dnf install chromium and be done with it

linuxftw

hello-smile6 commented 2 years ago

btw i can just run sudo dnf install chromium and be done with it #linuxftw

Wish I could do that. Seriously. I don't use Windows because I want to, just saying.

jdev082 commented 2 years ago

last thing we need tabs then i can apply some patches and release 2.0

jdev082 commented 2 years ago

Features are already decided and being worked on