search

jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Make URL bar update when URL changes #97

Closed hello-smile6 closed 2 years ago

hello-smile6 commented 2 years ago

Just copied code from ninetails. :) I attached a proof-of-concept video.

https://user-images.githubusercontent.com/73048226/146273798-c3f8d2c3-08ef-4ca1-b557-97f8aeefc9f5.mp4

jdev082 commented 2 years ago

make it go in to testing then i'll merge

hello-smile6 commented 2 years ago

make it go in to testing then i'll merge

Okay.

hello-smile6 commented 2 years ago

Ugh!

hello-smile6 commented 2 years ago

Made it a draft because of conflicts. I'll fix them.

jdev082 commented 2 years ago

conflicts

hello-smile6 commented 2 years ago

conflicts

Resolved.

hello-smile6 commented 2 years ago

Don't merge yet, testing.

hello-smile6 commented 2 years ago

Testing was successful, ready to merge.

hello-smile6 commented 2 years ago

Does it work for you?

jdev082 commented 2 years ago

NO, its because of prettier PRETTIER KEEPS BREAKING CODE test AFTER USING PRETTIER. make the PR without prettier

hello-smile6 commented 2 years ago

NO, its because of prettier PRETTIER KEEPS BREAKING CODE test AFTER USING PRETTIER. make the PR without prettier

I did test after.

jdev082 commented 2 years ago

well i have the same plain white screen error, reverting. fix your code.

hello-smile6 commented 2 years ago

well i have the same plain white screen error, reverting. fix your code.

What error?

jdev082 commented 2 years ago

you broke FreeCat for the #3 time thank god for my testing system

there IS no error just CHECK UR SYNTAX

jdev082 commented 2 years ago

its not ur PR, testing branch must of been broken before...

hello-smile6 commented 2 years ago

Okay. I'll try to fix it. Could you show a screenshot?

hello-smile6 commented 2 years ago

its not ur PR, testing branch must of been broken before...

Strange.

hello-smile6 commented 2 years ago

I'll look for code that's designed for win32 and could break it.

hello-smile6 commented 2 years ago

@JaydenDev Why not just stop using Prettier, since it breaks everything?

jdev082 commented 2 years ago

well can you real quick fix main branch as I cant click the search icon to load a website @hello-smile6 prettier was your idea...

jdev082 commented 2 years ago

testing the PR on main, gotta fix main real quick tho

hello-smile6 commented 2 years ago

well can you real quick fix main branch as I cant click the search icon to load a website @hello-smile6 prettier was your idea...

Why not remove it, since it won't work right with it?

jdev082 commented 2 years ago

ayy it works on the main branch btw main branch wasnt broken i had it broken locally

hello-smile6 commented 2 years ago

ayy it works on the main branch btw main branch wasnt broken i had it broken locally

That explains it! I had a feeling that might have been why.

jdev082 commented 2 years ago

can you make a PR that removes prettier. since it is the whole reason why FreeCat pre-reset was broken.