search

jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Hey, we gotta wrap up and release 2.0 #99

Closed jdev082 closed 2 years ago

jdev082 commented 2 years ago

Add tabs real quick make em stable and we're ready.

hello-smile6 commented 2 years ago

I'll see if I can take the tabs code from ninetails and get something working.

jdev082 commented 2 years ago

hey hey stealing bad i dont want this to be a 35% ninetails fork

hello-smile6 commented 2 years ago

hey hey stealing bad i dont want this to be a 35% ninetails fork

I'm just using things that we could do ourselves and are too small to make a difference.

jdev082 commented 2 years ago

ok, ima fix the broken search icon while u do that

hello-smile6 commented 2 years ago

ok, ima fix the broken search icon while u do that

I thought I fixed that...

hello-smile6 commented 2 years ago

ok, ima fix the broken search icon while u do that

Already fixed. Just checked.

jdev082 commented 2 years ago

oh i needed to npm install

jdev082 commented 2 years ago

fixed it

jdev082 commented 2 years ago

make it to where when its showing the home page it doesn't show a long string in the search bar

file:///home/jmwills/GitHub/freecat/home.html isn't aesthetically pleasing.

hello-smile6 commented 2 years ago

make it to where when its showing the home page it doesn't show a long string in the search bar

file:///home/jmwills/GitHub/freecat/home.html isn't aesthetically pleasing.

Okay, will do. Should be easy.

jdev082 commented 2 years ago

maybe have it show "home" on the home page?

jdev082 commented 2 years ago

also for non-URLs (searching) can it use a search engine like DDG?

hello-smile6 commented 2 years ago

maybe have it show "home" on the home page?

Working on it, just need to figure out how we can send the URL of the homepage to the renderer process.

hello-smile6 commented 2 years ago

also for non-URLs (searching) can it use a search engine like DDG?

Sure. Wanna just use the Ninetails code for that (or maybe slightly modified)? :)

jdev082 commented 2 years ago

COPYING CODE FROM COMPETITORS teRrIble PraCticES

hello-smile6 commented 2 years ago

COPYING CODE FROM COMPETITORS teRrIble PraCticES

It's FOSS! Why not? Anyways, it wouldn't take much to implement some of the same omnibox behavior as Chromium.

hello-smile6 commented 2 years ago

Think I figured it out.

jdev082 commented 2 years ago

It is referred to as the URL bar, the nav bar (holding all the icons like search and reload).

hello-smile6 commented 2 years ago

It is referred to as the URL bar, the nav bar (holding all the icons like search and reload).

I know. Also, I don't have the homepage URL showing for me. I'll work on that.Never mind, it shows it for me.

hello-smile6 commented 2 years ago

101 partially fixes the homepage problem. It might fix it entirely soon.

webdev03 commented 2 years ago

You all really need to use Prettier if you spent so much time setting it up but don't format or do any styling with your code. That will be the best thing for 2.0.

jdev082 commented 2 years ago

100

btw @webdev03 prettier ruins code.