search

jdewit / bootstrap-timepicker

[Deprecated] A simple timepicker component for Twitter Bootstrap
MIT License
1.64k stars 1.09k forks source link

2 issues using arrow keys to jump to minute #251

Open westrac opened 9 years ago

westrac commented 9 years ago

Hi,

I came up on 2 problems when using right arrow key to jump to minute.

  1. changing hour from 1 to 6, then right arrow key, then pressing up / down to change the minute, the hour jumps back to 1.
  2. changing hour from 1:00 to 12, then pressing arrow keys, now :0 will be selected and and starting to type will remove the : and change the time to a long number.
mrhota commented 9 years ago

Does this happen with version 0.5?

westrac commented 9 years ago

this is almost perfect now. Those points mentioned are good, but I found one more problem; not as severe. When changing minutes, say from 15, you type in 45, but then you press up arrow key to get 46, it will increment from the 15, not the 45. I think this same applies to hours.

mrhota commented 9 years ago

The timepicker only updates when you move to a different field. That's what determines that you're "done" with a particular unit. So, if you type in this sequence 4,5,up in a field with "15" already there, the field will be overwritten as you mentioned. It's not clear to me that this is a defect.

Thoughts?