search

jdewit / bootstrap-timepicker

[Deprecated] A simple timepicker component for Twitter Bootstrap
MIT License
1.64k stars 1.09k forks source link

bootstrap-timepicker.css don't install as part of bower package #338

Open ALysogorsky opened 8 years ago

ALysogorsky commented 8 years ago

I install bootstrap-timepicker as bower package bower install bootstrap-timepicker But css folder contains only timepicker.less

How can linked to bootstrap-timepicker.css without compiling less to css in client? I think it's a good practice to include in bower package all files that ready for deploy

mrhota commented 8 years ago

Right now, the css and min.js files are build artifacts. They therefore do not belong in source control.

I just read this solution. I'll implement jquery's approach here soon. It's the best we can probably hope for until Bower's devs realize deploying direct from source control is a bad idea.

JohnMacAslan commented 8 years ago

What's the status on this?

pedroresende commented 8 years ago

@mrhota Any news on this ?

mrhota commented 8 years ago

@JohnMacAslan @pedroresende @ALysogorsky I need help in this regard. It is not good practice (even if it's common practice) to keep build artifacts in source repos. If you know how to make bower build css on install, that might be the easiest solution. Alternatively, I'd be willing to ditch bower for something else that lets us build-on-install or otherwise keep build artifacts out of the repo.

Chosko commented 8 years ago

@mrhota Why do you say it's not a good practice to keep built js and css in source repos?

  1. It's not nice to force developers to install a LESS preprocessor/JS minifier if they just want to download a ready-to-go built version of your project (not everybody use Grunt and bower)
  2. It allows for easy inclusion of built files in a project via bower (let's say a dev choose Sass instead of Less for his project... He don't want to switch to LESS just to include a lib... and he don't even want to cd into the repo to build things)
  3. You can use a git hook to build the project before to push upstream, so every build belongs to their commit...
  4. In this way you let GIT make what's meant for: version your code - even the builds
  5. Everybody's doing it - and these are the reasons

;-)

CJYate commented 8 years ago

I'm trying to use this plugin from a Rails app with scss/sass templates. I don't want to use another css preprocessor!

So of course now I've an unmaintained, online-converted file in my own stylesheets folder. Not cool.

rwitchell commented 8 years ago

very true @mrhota, here's to hoping Bower team fix up this issue. However, probably still a good idea for you to include it - as not everyone is compiling their dependencies, and if they are, those people will ignore your minified artifact anyway. better to meet the demands of all of your customers ;) @ public in the mean time, use online tools like https://jscompress.com/ , http://less2css.org/ , https://cssminifier.com/ , to get your file.