jdewit / bootstrap-timepicker

[Deprecated] A simple timepicker component for Twitter Bootstrap
MIT License
1.64k stars 1.09k forks source link

Bootstrap 4 Support #362

Open alensiljak opened 7 years ago

alensiljak commented 7 years ago

Hi,

I'm adding the time picker to a Bootstrap 4 project and am willing to help adapt the code.

The only significant change I've identified so far is the removar of Glyphicons in BS4. Hence, there would be a need to default the arrow icons to something else. What would be the recommended approach?

So far, I've modified the bootstrap-timepicker.js

    icons: {
        //up: 'glyphicon glyphicon-chevron-up',
        up: 'fa fa-chevron-up',
        //down: 'glyphicon glyphicon-chevron-down'
        down: 'fa fa-chevron-down'
    },

and this seems to work. No other changes so far.

I would like to submit a PR but am not sure if this significantly affects the previous versions, existing users, or whatever.

Edit: With the configuration for the 'icons' option, this is even easier. No need to modify the original code.

 icons: {
            up: 'fa fa-chevron-up',
            down: 'fa fa-chevron-down'
        }
fdambrosio commented 7 years ago

thanks @MisterY