Closed diwi closed 7 years ago
Hi. I'm interested in this work, but right now there's a lot of commented lines, making it hard to understand the changes. It looks like you're still in the middle of working on it. Let me know when you're ready for me to review it.
The comments are the original code. Didn't want to get rid of it just yet.
But basically i think thats it.
I'm not sure about g.noLights();
though.
It is useful, but it is not mandatory for the beginHUD/endHUD scope to work.
When you're 100% ready for review (meaning, it 100% works, and there's no old code lying around), let me know.
Hi, cleaned up and ready to review.
"All checks have failed" ... not sure why this keeps popping up?
Ignore it.
I think it's all covered now. Are there further things to look for?
What is the setting that corresponds to undoing the ortho
call?
Thank you.
This update also handles resizeable windows
surface.setResizable(true);
... which is what brought me to this issue in the first place.
woohoo! I'll build and deploy.
beginHUD/endHUD seems to fail for custom set camera projections, e.g. a FoV different than 60 degrees. I just found this by accident and am a bit puzzled that I never encountered it before.
perspective(80 * DEG_TO_RAD, width/(float)height, 1, 5000);
Before: The rectangular border should align with the screen-border. Note, lightning also effects the shading of the HUD-scope.
After:
Example (also in the PR):