jdf / processing-py-site

Site for processing.py.
MIT License
197 stars 52 forks source link

The indentation is incorrect in the OOP car example #201

Open lanephillips opened 2 years ago

lanephillips commented 2 years ago

The first full script in this tutorial https://py.processing.org/tutorials/objects/ (the one with two cars going different speeds) will fail to run if copied and pasted into the Processing IDE. Some lines are not indented properly.

This works:

class Car(object):
    # The Constructor is defined with arguments.
    def __init__(self, c, xpos, ypos, xspeed):
        self.c = c
        self.xpos = xpos
        self.ypos = ypos
        self.xspeed = xspeed

    def display(self):
        stroke(0)
        fill(self.c)
        rectMode(CENTER)
        rect(self.xpos, self.ypos, 20, 10);

    def drive(self):
        self.xpos = self.xpos + self.xspeed;
        if self.xpos > width:
            self.xpos = 0

myCar1 = Car(color(255, 0, 0), 0, 100, 2)
myCar2 = Car(color(0, 255, 255), 0, 10, 1)

def setup():
    size(200,200)

def draw(): 
  background(255)
  myCar1.drive()
  myCar1.display()
  myCar2.drive()
  myCar2.display()
tabreturn commented 2 years ago

Thanks for spotting that! I've corrected this and created a pull request (https://github.com/jdf/processing-py-site/pull/202)

horstjens commented 2 years ago

the pull request was merged over a half year ago but the website https://py.processing.org/tutorials/objects/ still shows the incorrect indentation. Is there a way to publish the most recent version of the website with the corrections included?

Arghyahub commented 1 year ago

Please assign me this issue. I would like to contributing to the indentation issue addressed by @horstjens .

Arghyahub commented 1 year ago

Can anyone Merge my pull request please.