search

jdf2e / nutui-react

京东风格的移动端 React 组件库 、支持多端小程序(A React UI Toolkit for Mobile Web)
https://nutui.jd.com/react/
919 stars 263 forks source link

fix(infinite): loadingText未居中 #2683

Closed Alex-huxiyang closed 3 weeks ago

Alex-huxiyang commented 3 weeks ago

重复定义了classPrefix导致的

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

该拉取请求对 InfiniteLoadingDemo 组件中的 ScrollView 进行了修改，新增了 showScrollbar 属性并设置为 false，影响了滚动条的可见性。此外，对 InfiniteLoading 组件进行了多个类名的更新，将类名前缀从 'nut-infinite' 更改为 'nut-infiniteloading'，以反映新的命名约定。功能和逻辑保持不变，确保组件继续正常工作。

Changes

文件路径 更改摘要
src/packages/infiniteloading/demo.taro.tsx 在 ScrollView 组件中新增 showScrollbar 属性，设置为 false。
src/packages/infiniteloading/infiniteloading.taro.tsx 更新样式类名，将类名前缀从 'nut-infinite' 更改为 'nut-infiniteloading'，保持功能不变。

Possibly related PRs

Suggested reviewers

Poem

在无尽的加载中，
滚动条悄然隐，
类名换新装，
组件依旧行。
小兔欢跃跳，
代码更美丽，
让我们一起庆祝吧！ 🐇✨

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 9f167ea62d511fd50d310bc034956e3001096647 and 10a92d3dd01430d44db00949d3d40947dd9164fe.
📒 Files selected for processing (2) * `src/packages/infiniteloading/demo.taro.tsx` (1 hunks) * `src/packages/infiniteloading/infiniteloading.taro.tsx` (2 hunks)
🔇 Additional comments (3)
src/packages/infiniteloading/demo.taro.tsx (1) `43-46`: **请确认隐藏滚动条是否必要** 这个改动似乎与修复加载文本居中的问题无关。隐藏滚动条可能会影响用户体验，特别是在内容较长需要滚动时。建议： 1. 如果这个改动确实必要，请说明原因 2. 如果与当前PR目标无关，建议在单独的PR中处理此更改 让我们确认一下这个改动的必要性：
src/packages/infiniteloading/infiniteloading.taro.tsx (2) `192-199`: **类名规范化修改正确** 将动态类名更改为静态类名的修改是合理的，这样可以确保加载文本的样式更加可控和一致。具体改动： - 顶部提示区域使用 `nut-infinite-top` 和 `nut-infinite-top-tips` - 内容容器使用 `nut-infinite-container` - 底部提示区域使用 `nut-infinite-bottom` 和 `nut-infinite-bottom-tips` 这些更改有助于解决加载文本未居中的问题。 --- `77-77`: _:hammer_and_wrench: Refactor suggestion_ **建议重构：移除未使用的 classPrefix 变量** 代码中定义了 `classPrefix` 变量，但在模板中使用了静态的类名。这种不一致可能会导致维护困难。建议移除未使用的变量或统一使用动态类名。 ```diff -const classPrefix = `nut-infiniteloading` ``` > Likely invalid or redundant comment.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.95%. Comparing base (9f167ea) to head (10a92d3). Report is 2 commits behind head on V3.0.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## V3.0 #2683 +/- ## ======================================= Coverage 83.95% 83.95% ======================================= Files 221 221 Lines 17849 17849 Branches 2679 2679 ======================================= Hits 14986 14986 Misses 2858 2858 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.