search

jdf2e / nutui-react

京东风格的移动端 React 组件库 、支持多端小程序(A React UI Toolkit for Mobile Web)
https://nutui.jd.com/react/
919 stars 263 forks source link

fix(avatar): 恢复icon，适配鸿蒙 #2719

Closed xiaoyatong closed 2 weeks ago

xiaoyatong commented 2 weeks ago

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

此次变更主要集中在头像组件的样式和渲染逻辑的简化上。CSS 文件中对 .nut-avatar 类添加了 flexbox 布局属性，同时移除了多个子类的冗余属性。此外，头像组件的渲染逻辑也进行了简化，移除了对 harmonyAndRn() 函数的条件检查，确保组件在不同平台上的一致性和简洁性。

Changes

文件路径 变更摘要
src/packages/avatar/avatar.harmony.css 修改 .nut-avatar 类，添加 flexbox 属性，移除多个子类的冗余属性和类。
src/packages/avatar/avatar.scss 修改 .nut-avatar 类，添加 flexbox 属性，移除子类的冗余布局和尺寸属性。
src/packages/avatar/avatar.taro.tsx 修改头像组件的渲染逻辑，简化 icon 的处理，移除条件检查，确保一致的渲染结构。
src/packages/avatar/demo.taro.tsx 移除对 harmonyAndRn() 的条件渲染，确保 Demo4 和 Demo5 始终显示。
src/packages/avatar/demos/taro/demo2.tsx 移除对 harmonyAndRn() 的条件渲染，简化 Avatar 组件的渲染逻辑。
src/packages/avatar/demos/taro/demo3.tsx 移除对 harmonyAndRn() 的条件渲染，直接渲染三个 Avatar 组件。
src/packages/avatar/demos/taro/demo4.tsx 新增 User 图标的导入，修改 Avatar 组件的 icon 属性以包含该图标。
src/packages/avatar/demos/taro/demo6.tsx 移除对 harmonyAndRn() 的条件渲染，简化 Avatar.Group 组件的渲染逻辑。
src/packages/avatar/demos/taro/demo7.tsx 移除对 harmonyAndRn() 的条件渲染，统一渲染 Avatar.Group 组件。
src/packages/avatar/demos/taro/demo8.tsx 移除对 harmonyAndRn() 的条件渲染，确保始终显示带有图标的 Avatar。
src/packages/input/input.harmony.css 新增 .nut-input-clear 类，设置 flex: 0;，提供新的样式选项。
src/packages/skeleton/demos/taro/demo5.tsx 移除 Avatar 组件的 icon 属性中的 Image 组件，直接使用 src 属性。

Possibly related PRs

Suggested labels

size/XL

Suggested reviewers

Poem

在草地上跳跃的小兔，
头像样式焕然一新，
渲染逻辑更简洁，
用户图标闪闪发光，
一起欢庆这变化，
让我们一起欢笑，
兔子们的快乐无比！ 🐇✨

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between a89bdd97153ea6d7342a9ad4985552f3166f91f7 and a5bc46dc62a56f14748c518f48b57799dcc17ec2.
📒 Files selected for processing (1) * `src/packages/avatar/avatar.taro.tsx` (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * src/packages/avatar/avatar.taro.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.99%. Comparing base (f840bc7) to head (a5bc46d). Report is 19 commits behind head on V3.0.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## V3.0 #2719 +/- ## ========================================== + Coverage 83.95% 83.99% +0.03% ========================================== Files 221 221 Lines 17842 17878 +36 Branches 2675 2676 +1 ========================================== + Hits 14980 15016 +36 Misses 2857 2857 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oasis-cloud commented 2 weeks ago
image

taro h5 图片未居中

image

微信小程序图片未居中

image

鸿蒙

xiaoyatong commented 2 weeks ago
image image