search

jdf2e / nutui-react

京东风格的移动端 React 组件库 、支持多端小程序(A React UI Toolkit for Mobile Web)
https://nutui.jd.com/react/
918 stars 263 forks source link

feat(image): support icon demo #2728

Closed Alex-huxiyang closed 1 week ago

Alex-huxiyang commented 1 week ago

taro components中Image的onError事件在鸿蒙下没有触发

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

本次更改涉及多个组件的渲染逻辑和布局调整。ImageDemo 组件的加载和错误状态的控制流进行了简化，确保加载状态始终可见，而错误状态仅在特定条件下显示。Demo3 和 Demo4 组件引入了 pxTransform 函数，以实现响应式设计，替换了硬编码的宽度值。Image 组件的条件渲染逻辑也进行了调整，确保加载和错误图像始终显示。

Changes

文件路径 更改摘要
src/packages/image/demo.taro.tsx 添加 harmony 导入，简化加载和错误状态的渲染逻辑，确保加载状态始终可见。
src/packages/image/demos/taro/demo1.tsx 移除 pxTransform 导入，直接将 Image 组件的 height 属性设置为 200，并用 Cell 包裹。
src/packages/image/demos/taro/demo2.tsx 更新三个 Image 组件的 width、height 和 radius 属性，直接使用数值替代 pxTransform，并用 Cell 包裹。
src/packages/image/demos/taro/demo3.tsx 引入 pxTransform 函数，替换 View 和 Image 组件的硬编码宽度值，实现响应式设计，并用 Cell 包裹。
src/packages/image/demos/taro/demo4.tsx 添加 pxTransform 导入，更新 Image 和 View 组件的布局以使用响应式宽度，保持错误处理不变，并用 Cell 包裹。
src/packages/image/demos/taro/demo5.tsx 将 Image 组件的 width 和 height 属性从 pxTransform(30) 改为直接使用 30，并用 Cell 包裹。
src/packages/image/demos/taro/demo6.tsx 将 Image 组件的 width 和 height 属性从 pxTransform 改为直接使用 80，并用 Cell 包裹。
src/packages/image/demos/taro/demo7.tsx 将 Image 组件的 width 和 height 属性从 pxTransform 改为直接使用 80，并用 Cell 包裹。
src/packages/image/image.taro.tsx 移除 harmonyAndRn() 的条件渲染，确保加载和错误状态始终显示，定义默认属性但不做其他更改。

Possibly related PRs

Suggested labels

size/M

🐰 在草地上跳跃，变化如春风，
加载与错误，清晰而从容。
响应式设计，宽度随心动，
组件更美，功能更通。
让我们一起欢庆，代码如诗中！ 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.98%. Comparing base (1a61cc2) to head (2752082). Report is 2 commits behind head on V3.0.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## V3.0 #2728 +/- ## ======================================= Coverage 83.98% 83.98% ======================================= Files 221 221 Lines 17874 17874 Branches 2676 2676 ======================================= Hits 15012 15012 Misses 2857 2857 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xiaoyatong commented 1 week ago

demo中 image 的宽高可以不用显式的指定，可以在 组件实现里 把 pxcheck做一步优化。