search

jdf2e / nutui-react

京东风格的移动端 React 组件库 、支持多端小程序(A React UI Toolkit for Mobile Web)
https://nutui.jd.com/react/
918 stars 263 forks source link

fix(progress): fix style & support icon demo #2729

Closed Alex-huxiyang closed 2 days ago

Alex-huxiyang commented 1 week ago

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

本次更改涉及多个组件的修改，主要集中在ProgressDemo、Demo4、Demo6、progress.scss和progress.taro.tsx文件中。ProgressDemo组件的条件渲染被移除，Demo4组件的图像尺寸属性格式进行了调整，Demo6组件添加了新的样式和简化了条件渲染逻辑。此外，progress.scss文件中对文本位置的CSS样式进行了修改，而progress.taro.tsx文件中则调整了文本相对于进度条的定位。

Changes

文件路径 更改摘要
src/packages/progress/demo.taro.tsx 移除Demo4组件的条件渲染，Demo4及其头部无条件渲染。
src/packages/progress/demos/taro/demo4.tsx 将Image组件的width和height属性从字符串格式改为数字格式。
src/packages/progress/demos/taro/demo6.tsx 添加pxTransform工具函数，简化Checked和Tips组件的条件渲染，统一使用iconStyle样式。
src/packages/progress/progress.scss 修改.nut-progress-text类的CSS属性，调整文本位置以支持RTL布局。
src/packages/progress/progress.taro.tsx 修改getTextStyle函数中right和left属性的返回值为固定的'100%'，调整文本相对于进度条的位置。
src/packages/progress/__tests__/progress.spec.tsx 更新inner元素的样式断言，简化背景颜色的CSS属性。
src/packages/progress/demos/h5/demo4.tsx 将Image组件的width和height属性从字符串格式改为数字格式，并更新src属性为新URL。
src/packages/progress/demos/h5/demo6.tsx 将Progress组件的颜色属性从RGBA格式更新为RGB格式。
src/packages/progress/progress.tsx 修改stylesInner对象中的backgroundColor属性为background，对齐CSS标准。
src/styles/variables.scss 更新多个颜色变量以使用新的CSS自定义属性，标准化颜色使用。

Possibly related PRs

Suggested labels

size/L

Suggested reviewers

🐰 在进度条上跳跃，
组件变得更加明亮，
条件渲染已不再，
图像尺寸轻松改，
风格统一真美好，
兔子欢快乐逍遥！ 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.98%. Comparing base (6714eb4) to head (14105a5). Report is 7 commits behind head on V3.0.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## V3.0 #2729 +/- ## ========================================== - Coverage 83.98% 83.98% -0.01% ========================================== Files 221 220 -1 Lines 17879 17876 -3 Branches 2676 2676 ========================================== - Hits 15016 15013 -3 Misses 2858 2858 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: