search

jdf2e / nutui

京东风格的移动端 Vue 组件库，支持多端小程序(A Vue.js UI Toolkit for Mobile Web)
https://nutui.jd.com
MIT License
6.01k stars 814 forks source link

feat(tabbar): add prop before-switch #3060

Closed eiinu closed 1 week ago

eiinu commented 2 months ago

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

这个 PR 涉及以下平台:

这个 PR 是否已自测:

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

这次更新主要涉及为Vue插件添加新的ESLint规则，以及在多个Vue组件和文档中引入新的beforeSwitch功能。这个功能允许在切换标签之前执行异步检查逻辑，增强了标签切换的灵活性和可控性。

Changes

文件路径 修改摘要
packages/nutui-eslint-config/index.js 添加了新的ESLint规则'no-empty'。
.../nutui-taro-demo/src/nav/pages/tabbar/before-switch.vue
.../__VUE/tabbar/demo/before-switch.vue
.../__VUE/tabbar/demo/index.vue		 新增了before-switch.vue组件，包含标签切换逻辑。
src/packages/__VUE/tabbar/__tests__/index.spec.tsx 更新了测试描述，添加了props.beforeSwitch功能的测试。
src/packages/__VUE/tabbar/doc.en-US.md
src/packages/__VUE/tabbar/doc.md
src/packages/__VUE/tabbar/doc.taro.md		 更新了文档，添加了before-switch回调函数的描述，并修改了v-model参数类型。
src/packages/__VUE/tabbar/tabbar.taro.vue
src/packages/__VUE/tabbar/tabbar.vue		 引入了beforeSwitch属性，更新了changeIndex函数以处理异步beforeSwitch检查。
src/packages/__VUE/tabbaritem/tabbar-item.taro.vue
src/packages/__VUE/tabbaritem/tabbar-item.vue		 重构了change函数为异步函数，并添加了错误处理逻辑。

🐰✨

代码如诗，变化如梦， 标签切换，灵活掌控。 异步检查，前路通畅， ESLint新规，代码更强。 Vue中绽放，创新无疆， 代码世界，因你而亮。

— CodeRabbit

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.98%. Comparing base (87f044d) to head (3863c1e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v4 #3060 +/- ## ========================================== - Coverage 83.99% 83.98% -0.02% ========================================== Files 226 226 Lines 22939 22941 +2 Branches 2476 2482 +6 ========================================== - Hits 19268 19267 -1 - Misses 3653 3656 +3 Partials 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.