search

jdf2e / nutui

京东风格的移动端 Vue 组件库，支持多端小程序(A Vue.js UI Toolkit for Mobile Web)
https://nutui.jd.com
MIT License
6.01k stars 815 forks source link

fix(textarea): 修复 slot 嵌套使用 textarea 时的输入失焦问题 #3084

Closed eiinu closed 1 month ago

eiinu commented 1 month ago

这个 PR 做了什么? (简要描述所做更改)

场景：textarea 的使用层级较深（即被多层组件包裹使用）时，输入会触发失去焦点，导致无法连续输入 代码：当 autofoucs 设置为 false 时，上述场景会被触发 解决办法：当 autofocus 为 true 时设置属性，否则不设置

历史提交： https://github.com/jdf2e/nutui/commit/810cb85c161f33497470cb18d23e3f83866edb69

2123

关联信息： NutUI Taro 中的 Textarea 组件中使用的是 HTML 标签 textarea，会被 Taro 的插件 @tarojs/plugin-html 转换为小程序原生的 textarea，其中 auto-focus 属性会被映射为 focus

这个 PR 是什么类型? (至少选择一个)

这个 PR 涉及以下平台:

这个 PR 是否已自测:

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

此次修改主要集中在 src/packages/__VUE/textarea/textarea.taro.vue 文件中，对 auto-focus 属性进行了调整。现在该属性将根据 autofocus 的值有条件地设置为 true 或 undefined，以便更灵活地控制自动聚焦功能。

Changes

文件路径 修改摘要
src/packages/__VUE/textarea/textarea.taro.vue 将 :auto-focus="autofocus" 修改为 :auto-focus="autofocus ? true : undefined"

🐇✨ 代码如诗，变幻无穷， 聚焦随心，灵活自如。 改动虽小，意蕴深长， 未来之路，代码护航。 🌟📜

[!WARNING]

Review ran into problems

Problems (1) * Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.96%. Comparing base (0c84db1) to head (4837f5b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v4 #3084 +/- ## ========================================== - Coverage 83.98% 83.96% -0.03% ========================================== Files 226 226 Lines 22939 22939 Branches 2479 2475 -4 ========================================== - Hits 19266 19260 -6 - Misses 3655 3661 +6 Partials 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.