search

jdf76 / plugin.video.youtube

Kodi's Youtube Plugin -- Please Check the forums before submitting an issue
https://ytaddon.page.link/forum
392 stars 117 forks source link

AV1, Opus and Vorbis #257

Open anxdpanic opened 6 years ago

anxdpanic commented 6 years ago

> 1080p and additional audio streams use VP9, and Opus codecs in a webm container and av1 in mp4 container which are currently unsupported by inputsteam.adaptive

greystashh commented 6 years ago

Would this be a temporary workaround?

http://wiki.webmproject.org/adaptive-streaming/instructions-to-playback-adaptive-webm-using-dash

anxdpanic commented 6 years ago

We can't use anything there. We already have the dash file, our issue is playback, those instructions use web based and external app for playback.

Using an external/alternative player like VLC 3 in Kodi and the add-on may actually work, I've never tried but everything is already in the add-on for that. The only thing that for sure won't work with external player is 'My Channel' videos.

greystashh commented 6 years ago

But can you say what's the problem with playback? I thought kodi is capable playing webm files

anxdpanic commented 6 years ago

Because it's dash, inputstream.adaptive handles the processing not core and VP9 and webm currently not supported there.

We could probably play the video stream or audio streams by themselves with core, but we can't mux them as core doesn't support that. That would require an inputstream add-on.

In Kodi 18 we include the VP9 and webm streams in the dash file since we can and then they should work if/when support is added to inputstream.adaptive.

greystashh commented 6 years ago

So the difficulty is to mux video and audio with input stream to make it playable? For mp4 this is not necessary?

anxdpanic commented 6 years ago

The non dash is already combined audio, and video but 720 or lower.

The dash urls are separate audio, and video streams(see example in #53), inputstream.adaptive plays separate audio, and video streams from the dash file and currently supports mp4 so those work. Not sure it's true muxing but I hope that clarifies.

greystashh commented 6 years ago

Yes. You don't know whether the method of muxing mp4 audio&video can be adopted to webm?

anxdpanic commented 6 years ago

afaik it can be, it just has to be written, but I don't know if or when that will happen. And I don't know any C variant so at this point I can't really contribute to that.

greystashh commented 6 years ago

Have you talked to peak lately again?

anxdpanic commented 6 years ago

I haven't, but there is an open issue with a sample and I'm sure he'll update the issue if/when he decides to undertake it, or someone else with the required skills decides to help out.

anxdpanic commented 5 years ago

6.4.0 enables webm-vp9, requires inputstream.adaptive >= 2.3.14 https://github.com/jdf76/plugin.video.youtube/wiki/Installation Submitted and waiting review to the Official repository as well