search

jdg / MBProgressHUD

MBProgressHUD + Customizations
http://www.bukovinski.com/
MIT License
16.01k stars 3.56k forks source link

Cocoapods – tvos support #315

Closed psmejkal closed 8 years ago

matej commented 8 years ago

Is this all it takes to get it working on tvos? #312

psmejkal commented 8 years ago

Yes, I'm already using the forked version in one of my apps.

pmusolino commented 8 years ago

+1 to approve this pull request

psmejkal commented 8 years ago

Inconsistent formating fixed. Deployment target for iOS changed to the correct version (4.3).

matej commented 8 years ago

The static lib is set to 6.0. Kind of hard to test for even that though. :)

Why does it need to be explicitly listed now? Worked without it before for iOS.

arsonik commented 8 years ago

As its said in the official documentation https://guides.cocoapods.org/syntax/podspec.html#deployment_target

New libraries that do require ARC and have a deployment target of = iOS 6.0 or OS X >= 10.8:

Because MBProgressHUD does require arc then the correct patch should be :

s.ios.deployment_target = '6.0'
s.tvos.deployment_target = '9.0'

But there is still an issue : Pods/MBProgressHUD/MBProgressHUD.m:993:11: 'UIToolbar' is unavailable: not available on tvOS

Edit: I've just added created a new pull request that handle the issue https://github.com/jdg/MBProgressHUD/pull/357

Bo98 commented 8 years ago

That documentation is about dispatch_release - something MBProgressHUD does not use. You'll see there is also a bullet point that says:

New libraries that do require ARC, but have a deployment target of < iOS 6.0 or OS X < 10.8

That said, Xcode requires iOS 6 for bitcode so it is the minimum that many people are adopting.

matej commented 8 years ago

Merged #357 which handles this and some other details.