search

jdg / MBProgressHUD

MBProgressHUD + Customizations
http://www.bukovinski.com/
MIT License
16.01k stars 3.56k forks source link

Improve auto layout code #339

Open matej opened 8 years ago

matej commented 8 years ago

Constraints are currently recreated whenever the configuration changes. Reusing them would be nicer, but could potentially produce way messier code. Not sure how to best handle this. Also not sure if it's worth the trouble. Suggestions welcome.

danielphillips commented 8 years ago

Just a quick note to say that your-updateConstraints method should call [super updateConstraints] at the end of the method as per documentation.

https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIView_Class/#//apple_ref/occ/instm/UIView/updateConstraints

matej commented 8 years ago

Thanks. Addressed in https://github.com/jdg/MBProgressHUD/commit/89218d6043a648a65077229e719373abe6951b9a.