search

jdg / MBProgressHUD

MBProgressHUD + Customizations
http://www.bukovinski.com/
MIT License
16.01k stars 3.56k forks source link

Added support for NSProgress #372

Closed alistra closed 8 years ago

alistra commented 8 years ago

This is a pull request for #347.

Please tell me if adding CADisplayLink (and QuartzCore dependency) is OK. I believe it's a good solution, because then we don't have to depend on NSProgress object providers to not update the object too often, resulting in starving the main thread.

Not sure if hideAnimated: is the correct place to invalidate the display link, or maybe there is a better place for it.

Please also tell me if the API I proposed is OK.

matej commented 8 years ago

Thanks! LGTM. Merged manually and added a few additional tweaks.