search

jdg / MBProgressHUD

MBProgressHUD + Customizations
http://www.bukovinski.com/
MIT License
16.01k stars 3.56k forks source link

Why not keep the completionBlock? #384

Closed hulizhen closed 8 years ago

hulizhen commented 8 years ago

Hi.

In the latest version, it seems that you guys are considering to remove the completionBlock and replace it with the MBProgressHUDDelegate instead?

In my/some case, the completionBlock is a much more elegant approach to reduce code separation and global variables in comparison to the MBProgressHUDDelegate which kinda messing up my code.

How about keeping both completionBlock and MBProgressHUDDelegate?

matej commented 8 years ago

The reason for removing it was mainly that it was mainly meant for the GCD helper that got deprecated. But fair enough. I brought it back in 383e8f51310d803838b49f22fea9e4e316f1339c.