Open idelrich opened 7 years ago
@shubh10 It's good, but i need grace
feature.
Can you be more specific?
Stephen
On Aug 30, 2017, at 4:36 PM, Nik Kov notifications@github.com wrote:
@shubh10 https://github.com/shubh10 It's good, but i need grace feature.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jdg/MBProgressHUD/pull/488#issuecomment-326111412, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJI9xwZilLIvPars1DP05_5GOH15Oasks5sdcfdgaJpZM4OW82k.
/*
* Grace period is the time (in seconds) that the invoked method may be run without
* showing the HUD. If the task finishes before the grace time runs out, the HUD will
* not be shown at all.
* This may be used to prevent HUD display for very short tasks.
* Defaults to 0 (no grace time).
*/
@property (assign, nonatomic) NSTimeInterval graceTime;
Also there are no blur effect for the background. And appearence animations.
graceTime is supported, almost at the top of the implementation file…
/*
* graceTime is the time (in seconds) that the invoked method may be run without
* showing the HUD. If the task finishes before the grace time runs out, the HUD will
* not be shown at all.
* This may be used to prevent HUD display for very short tasks.
* Defaults to 0 (no grace time).
*/
var graceTime:TimeInterval = 0.0
I’m not sure what you are referring to for blue effect and appearance animations, but anything that was marked deprecated in the objective-C version was not implemented.
Stephen
On Aug 31, 2017, at 4:19 AM, Nik Kov notifications@github.com wrote:
/*
- Grace period is the time (in seconds) that the invoked method may be run without
- showing the HUD. If the task finishes before the grace time runs out, the HUD will
- not be shown at all.
- This may be used to prevent HUD display for very short tasks.
- Defaults to 0 (no grace time). */ @property (assign, nonatomic) NSTimeInterval graceTime; Also there are no blue effect for the background. And appearence animations.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jdg/MBProgressHUD/pull/488#issuecomment-326225162, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJI94m1fee9kc0gvMMt50jefJZNiJP5ks5sdmyWgaJpZM4OW82k.
I'm playing with it. Thoughts...
static func hideHUDFor(_ view: UIView, animated: Bool = true) -> Bool
Should probably have a discardableResult.
Why is the bezelview private? (rhetorical question)
Good work.
On Oct 20, 2017, at 11:41 AM, Chris Van Buskirk notifications@github.com wrote:
I'm playing with it. Thoughts...
static func hideHUDFor(_ view: UIView, animated: Bool = true) -> Bool Should probably have a discardableResult.
Agreed.
Why is the bezelview private? (rhetorical question)
That’s the way it is in the Objective-C version. This is an almost true port.
Good work.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jdg/MBProgressHUD/pull/488#issuecomment-338243378, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJI9xGMSVoQQimKVTnTapeB-nlXaHFWks5suL8fgaJpZM4OW82k.
Finally, you have several warnings to update. I implemented it and it's working well.
Is anyone working on this PR or is it abandoned? I have several thoughts on this implementation and I can help with the PR review.
I am still actively using the library (in Swift) and am open to keeping the Swift part moving forward.
On Nov 26, 2018, at 11:09 AM, tomaszmaciejko notifications@github.com wrote:
Is anyone working on this PR or is it abandoned? I have several thoughts on this implementation and I can help with the PR review.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jdg/MBProgressHUD/pull/488#issuecomment-441696335, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJI96jf5PjYv-7dlJUOh-MksHrFZpL7ks5uzBJPgaJpZM4OW82k.
I did a swift version of the MBProgressHUD: https://github.com/growup-together/KProgressHUD
Wish for help.
Initial commit of MBProgressHUD in swift.