search

jdg / MBProgressHUD

MBProgressHUD + Customizations
http://www.bukovinski.com/
MIT License
16.01k stars 3.56k forks source link

change deployment target to iOS 9 to fix Archiving with Xcode 12 #608

Closed dvshelley closed 4 years ago

simonyangme commented 4 years ago

@matej any chance you can take a look at this PR? iOS 8 is no longer supported as a deployment target with Xcode 12's release.

tinder-owenthomas commented 4 years ago

Bump for this one. We cannot upgrade to Xcode 12 until this warning can be silenced. Any chance of getting this merged and a new version released?

matej commented 4 years ago

This is pretty easy to work around by adding something like the following in your pod file:

post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '9.0'
    end
  end
end

I use that myself.

That being said, I think it's fine to jump to V9. Based on a quick check, I don't see any new warnings.

tinder-owenthomas commented 4 years ago

@matej I think it needs to be updated here as well https://github.com/jdg/MBProgressHUD/blob/master/MBProgressHUD.podspec#L15

And any chance we can get a tagged version bump to 1.3.0 so we can pull these changes in without having to point to a commit? 🙏