search

jdg / MBProgressHUD

MBProgressHUD + Customizations
http://www.bukovinski.com/
MIT License
16.01k stars 3.56k forks source link

Update minimum deployment target to iOS 9.0 and minor version bump #616

Closed tinder-owenthomas closed 3 years ago

tinder-owenthomas commented 3 years ago

Expands upon #608 by making sure the Cocoapods system recognizes the minimum target.

Xcode 12 no longer supports iOS 8 and throws warnings if any frameworks use a lower minimum deployment target. This PR updates the deployment target in the podspec. I didn't see any other places it needs to be updated but am happy to update other locations if they exist.

I've included a minor version bump in the podspec since this is a semi-breaking change as it will no longer support anyone who is developing for iOS 8 - although since Apple doesn't support that type of development anyway it seems unlikely and therefore not worthy of a major bump.

tinder-owenthomas commented 3 years ago

@matej This repo won't allow me to add you as a reviewer. Just wanted to check and see if there's a process I should go through to get PRs reviewed. I think this PR is necessary to fully accomplish the changes intended in #608.

Please let me know if there's any way I can help.

tinder-owenthomas commented 3 years ago

Updating the build number is a separate step that should be done just before the release as part of that process. Otherwise LGTM. Thank you for the contribution.

@matej Sounds good, I've reverted the version bump portion of the PR.

Would love to see this merged and included in a release whenever possible as it is currently blocking our adoption of Xcode 12 🙏. Thank you!

matej commented 3 years ago

You can just point to a commit in the meantime.