Fix UIKit import issue while using MBProgressHUD framewok in Package …

jdg / MBProgressHUD

MBProgressHUD + Customizations

http://www.bukovinski.com/

MIT License

16.01k stars 3.56k forks source link

Fix UIKit import issue while using MBProgressHUD framewok in Package … #625

Closed yadavsunil closed 3 years ago

yadavsunil commented 3 years ago

I am using MBProgressHUD in one of my framework. This framework has Swift.package file which has MBProgressHUD

.package(name: "MBProgressHUD", url: "https://github.com/jdg/MBProgressHUD.git", from: "1.2.0")

When I try to build or test my framework using command swift build & swift test Getting below error.

I have verified after these changes both swift build & swift test working fine.

yadavsunil commented 3 years ago

@matej & @jdg This repo won't allow me to add you as a reviewer. Just wanted to check and see if there's a process I should go through to get PRs reviewed. I think this PR is necessary to fully accomplish to Swift Package Manager.

yadavsunil commented 3 years ago

@jdg @matej Could you review changes. So that we can use update changes in our Framework as well.

matej commented 3 years ago

This seems like it would be better solved by platform conditionals.

https://github.com/apple/swift-evolution/blob/master/proposals/0273-swiftpm-conditional-target-dependencies.md

yadavsunil commented 3 years ago

@matej Thanks a lot. Its fixed my issue. I am closing PR.