jdg / MBProgressHUD

MBProgressHUD + Customizations
http://www.bukovinski.com/
MIT License
16.01k stars 3.56k forks source link

Apple Privacy Manifest #647

Closed manahilov closed 8 months ago

manahilov commented 12 months ago

Hi team, Is there a plan to include the PrivacyInfo.xcprivacy manifest as required by Apple? ref: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files

Thanks, Boyan

LionWY commented 11 months ago

+1

zeroskylian commented 11 months ago

https://developer.apple.com/support/third-party-SDK-requirements/

brendand commented 11 months ago

+1

zziazm commented 11 months ago

+1

379800792 commented 11 months ago

+1

CH3COOH commented 10 months ago

Hello! Does anyone know which API used in MBProgressHUD is problematic?

threema-matteo commented 9 months ago

Hey @jdg , are there any updates on this?

liam-i commented 9 months ago

I made a Swift version of the HUD. https://github.com/liam-i/FlyHUD

Thanks a lot to Jonathan George for building MBProgressHUD - all my ideas and many implementation details were provided by his library.

This HUD does not use any data or API from the privacy manifest. And it's not on this list either.

If you are interested, please browse and provide valuable feedback.

adrianosouzapd commented 8 months ago

+1

brendand commented 8 months ago

@liam-i Will your Swift implementation also work from Objective-C?

liam-i commented 8 months ago

@liam-i Will your Swift implementation also work from Objective-C?

Cannot run directly on Objective-C. But bridging is possible, please refer to the HUD-Bridging-OC and OCPresentViewController.m files.

nmendiratta89 commented 8 months ago

+1

frankiebarrios commented 8 months ago

+1

theLittleApps commented 8 months ago

+1

percival888 commented 8 months ago

+1

shsw228 commented 8 months ago

+1

RideShi commented 8 months ago

+1

MrMage commented 8 months ago

Instead of replying with +1, could everyone please just press the "thumbs up" emoji on the original post and subscribe to notifications in the sidebar? If you post a "+1", everyone who is already subscribed to this thread gets an unneccessary notification.

manahilov commented 8 months ago

I made a Swift version of the HUD. https://github.com/liam-i/FlyHUD

Thanks a lot to Jonathan George for building MBProgressHUD - all my ideas and many implementation details were provided by his library.

This HUD does not use any data or API from the privacy manifest. And it's not on this list either.

If you are interested, please browse and provide valuable feedback.

Actually it is on the list - https://developer.apple.com/support/third-party-SDK-requirements, why I don't know. Just went trough the source and indeed it is not using any of the described APIs..

percival888 commented 8 months ago

According to Apple's requirements, even if the APIs that needs to be explained are not used, it's need to include a manifest to declare that they're not using any of the affected APIs or tracking anything. However, they must include such a file regardless.

manahilov commented 8 months ago

Thank you for the PR @CH3COOH, anyone with write permissions that can merge it? cc: @jdg

jdg commented 8 months ago

merged, thanks!

matrejek commented 8 months ago

@jdg would there be a chance to add new version tag on this change? It's obviously possible to target specific revision but targeting tag/version seems way cleaner :)

manahilov commented 8 months ago

Can someone open a PR with updated Swift package?

// swift-tools-version:5.9
import PackageDescription

let package = Package(
    name: "MBProgressHUD",
    products: [
        .library(name: "MBProgressHUD", targets: ["MBProgressHUD"])
    ],
    targets: [
        .target(
            name: "MBProgressHUD",
            dependencies: [],
            path: ".",
            exclude: ["Demo"],
            sources: ["MBProgressHUD.h", "MBProgressHUD.m"],
            resources: [.copy("PrivacyInfo.xcprivacy")],
            publicHeadersPath: "include"
        )
    ]
)

That should include the Privacy manifest when consuming the framework via SPM. I don't have permissions to create a PR.

Thank you in advance.

matrejek commented 8 months ago

I have opened #653 with the change as suggested by @manahilov - @jdg - could you have a look?