add check to skip init() of gContactSync

jobisoft commented 5 years ago

This is John from last weeks email regarding the UI clash with TbSync. Thanks for your friendly response.

This PR adds a little check to skip the init() of gContactSync.CardDialogOverlay, if the directory of that card has certain flag set. All TbSync directories will have that flag set :-).

In my view, stopping init() from being executed is even better, than trying to role back what init() has done.

jobisoft commented 5 years ago

Do not pull, I have to check something.

jobisoft commented 5 years ago

I changed it bit:

the XUL elements are now added as hidden and only if gContactSync is really injecting itself, they are unhidden via JS
the init() function is only checking if gContactSync should inject itself and if so, calls inject() (which calls itself again with timeout)
I updated the check to also work with mailing lists

The inject-check is now based upon the presence of the "gContactSyncSkipped" stringValue at the parent directory.

Is there a more basic check, to find out if the directory is a gContactSync address book? So the extra stringValue to prevent gContactSync from injecting is not needed?

jdgeenen / gcontactsync

add check to skip init() of gContactSync #127