nesquena
commented
10 years ago :+1: nice work Jeff. A few notes after checking out the code:
- Consider better organizing your source files
- Consider cleaning up your search activity such as re-using a single method for both initial load and pagination
- Nice to see you added the search to the ActionBar!
- Nice use of a dialog for the settings!
- DialogFragment shouldn't communicate with the activity that way. In the future, check the guides as communication should be triggered via an interface not explicit casting of the activity.
- Properly used spinners (with populated values) to allow users to select filters
- One thing to consider is rather than storing all the filter values separately as variables, might have introduced a model (i.e
SearchFilters.java) representing all the filters for better organization - Nice job adding the share intent to the image detail view although only half-working as it shares the URL as you mentioned
- Nice job with the swipe detection!
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
My ImageSearch app is completed. I added swipe gesture detection to the view image activity to navigate through image results. I was unable to save the image to the local storage, so I just shared the plain text link instead.
Hours: 9
-Jeff Good
/cc @nesquena @timothy1ee