search

jdgwf / battletech-tools

BattleTech and Alpha Strike mech utilities
https://jdgwf.github.io/battletech-tools/
MIT License
21 stars 9 forks source link

Wrong force pack content names+ fix for Unit Search Rules #43

Closed cam-smith closed 4 months ago

cam-smith commented 5 months ago

Solves #42

MUL has changed naming standards and removed "(standard)", and Added squad size to Elementals. See Sept 11, 2002, and June 6, 2022 entries at http://masterunitlist.info/Blog/Index .

Also to fix the rifleman search, had to change Rules Search. ',' appended by default into Rules field Value causes search to skip rules section. Changed string match to follow pattern, and fixed extra , in query string.

jdgwf commented 5 months ago

@cam-smith Than you so much! Are you pretty confident on a merge? I'm juggling a lot - too much to test this week

cam-smith commented 5 months ago

I'm confident on the data file updates, but don't know why the MUL lookup was doing what it was doing.... In my testing it worked, but i might have b0rked something elsewhere. ie. the "standard" logic. vs "intro+standard". If its'only used for the force packs it should be fine, I've only been topic spelunking, as opposed to groking the whole code base. I've also only fixed the Rules filter, leaving current behaviour for the other filters.

Rest of it should be good to go.

cam-smith commented 4 months ago

I ran another round of testing, looks good to go to me.

jdgwf commented 4 months ago

@cam-smith Cam, I'm so sorry about the delay on this. These last few months have been heck. This is live as well as some package and updates to bring react and react-scripts up to date with modern packages! :)

jdgwf commented 4 months ago

Thank you SO MUCH for your contributions to this project!