search

jdhartley / terminal-for-fitbit

Terminal is a Fitbit clock face styled to match a terminal session in a Unix environment
https://terminal.watch/
The Unlicense
132 stars 18 forks source link

Cannot add line unless all are removed #9

Closed exolon closed 4 years ago

exolon commented 4 years ago

In the app settings, if I remove a line, there's no way to add one. I have to remove ALL the lines before the "Add" option appears that lets me do so.

Minor bug, to be sure.

jdhartley commented 4 years ago

Hi @exolon, thanks for the bug report! I appreciate your time and am glad you are enjoying the clock face

I believe that you are seeing the "Add Action" button disappear during Edit mode. Here's my assumption:

  1. You open settings, scroll to "Clock face data"
  2. You see "All rows are full"
  3. You press "Edit"
  4. You remove a row
  5. EXPECTED: See "Add Item" button; ACTUAL: no button :cry:

Here's the workaround: If you press "Done", the rearrange/remove UI should close and the "Add Item" button should appear.

Let me know if my assumed reproduction steps/workaround are wrong, or you are not seeing this behavior on your device!

I did some brief research into this... I would like to improve this UX if possible

It looks like the <AdditiveList> component provided by Fitbit hides the addAction component while it is in Edit mode. Here's the code that is generating this UI

My first thought was adding a help message under the list during edit mode, but I don't see a way for me to detect the Edit mode starting/ending... sadly these components are pretty bare-bones.

I am open to ideas/suggestions here! Thanks again for your time

exolon commented 4 years ago

Good morning!

Yes, your assumptions were correct, that's the flow, and indeed the workaround works nicely.

It's not a biggie, one figures it out pretty quickly to be honest. But you could add the text anyhow, no need for it to be conditional on whether Edit mode is active or not - just put it under the section :)

jdhartley commented 4 years ago

Thanks for filing this bug report @exolon! This has been addressed in the just-released v2.0.1, now available in the Fitbit app.

exolon commented 4 years ago

Cheers, will check it out once the Gallery is up (hasn't been working for me since yesterday)!!