search

jdhenke / celestrium

A javascript library to visualize graphs.
MIT License
2 stars 1 forks source link

put in backbone v1.1.0 #57

Closed jdhenke closed 10 years ago

jdhenke commented 10 years ago

Initial Findings and Reactions

Findings

Reactions

You could get around this by manually assigning properties of the view after it's constructed, but I find this pretty shitty.

var viewObj = new MyView({
  // standard view options
});

// now hack on our own things
viewObj.customAttribute = "lame";

Short Term Conclusion

I'm annoyed, but can't decide if it's at Backbone for breaking stuff or for my poor design choices with my Views...

Gonna keep hacking until I get it working and we'll see how things look.

jdhenke commented 10 years ago

Didn't know this, but the arguments specified to the constructor of a View are passed to the initialize function.

So the basic solution I've implemented is to move functionality to initialize and save individual components of state as needed e.g. nodeSearch.js.

Still need to clean up and separate initialize vs. render in some cases.

jdhenke commented 10 years ago

@jhelbert @haosharon

Above, I've discussed and implemented the changes necessary to make Celestrium work with the latest Backbone release.

I'm in favor of using it because I don't want to get locked in to an old version of Backbone, but before merging I wanted to get your opinions. Any thoughts? If not just say "no" so I know you've seen this.

Enjoy your long weekends.

jhelbert commented 10 years ago

no, not familiar with backbone enough to have any input

On Fri, Oct 11, 2013 at 2:40 PM, jdhenke notifications@github.com wrote:

@jhelbert https://github.com/jhelbert @haosharonhttps://github.com/haosharon

Above, I've discussed and implemented the changes necessary to make Celestrium work with the latest Backbone release.

I'm in favor of using it because I don't want to get locked in to an old version of Backbone, but before merging I wanted to get your opinions. Any thoughts? If not just say "no" so I know you've seen this.

Enjoy your long weekends.

— Reply to this email directly or view it on GitHubhttps://github.com/jdhenke/celestrium/pull/57#issuecomment-26160954 .

haosharon commented 10 years ago

thumbs up

On Fri, Oct 11, 2013 at 2:43 PM, jhelbert notifications@github.com wrote:

no, not familiar with backbone enough to have any input On Fri, Oct 11, 2013 at 2:40 PM, jdhenke notifications@github.com wrote:

@jhelbert https://github.com/jhelbert @haosharonhttps://github.com/haosharon

Above, I've discussed and implemented the changes necessary to make Celestrium work with the latest Backbone release.

I'm in favor of using it because I don't want to get locked in to an old version of Backbone, but before merging I wanted to get your opinions. Any thoughts? If not just say "no" so I know you've seen this.

Enjoy your long weekends.

— Reply to this email directly or view it on GitHubhttps://github.com/jdhenke/celestrium/pull/57#issuecomment-26160954 .

Reply to this email directly or view it on GitHub: https://github.com/jdhenke/celestrium/pull/57#issuecomment-26161246