search

jdholtz / auto-southwest-check-in

A Python script that automatically checks in to your Southwest flight 24 hours beforehand.
GNU General Public License v3.0
460 stars 89 forks source link

Check-in changes #282

Closed dmytrokoren closed 3 months ago

dmytrokoren commented 4 months ago

Modified make_request and changed requests from GET to POST

jdholtz commented 4 months ago

Thanks for the PR @dmytrokoren. There are multiple different changes in this PR (changing how check-ins are done and better avoidance of 403/429). Could you split this into multiple PRs? You can keep this one for the 403/429 avoidance and make another for the check-in change. It'll make it easier to review each one individually and will help the repo history make more sense and easier to maintain.

Also, it doesn’t look like your branch is up to date with the latest develop changes. It’s missing the new _handle_southwest_error_code in the make_request function.

dmytrokoren commented 4 months ago

Thanks for the PR @dmytrokoren. There are multiple different changes in this PR (changing how check-ins are done and better avoidance of 403/429). Could you split this into multiple PRs? You can keep this one for the 403/429 avoidance and make another for the check-in change. It'll make it easier to review each one individually and will help the repo history make more sense and easier to maintain.

Also, it doesn’t look like your branch is up to date with the latest develop changes. It’s missing the new _handle_southwest_error_code in the make_request function.

Sure I'll split it and sync the changes.

dmytrokoren commented 4 months ago

This PR is related to #278

jdholtz commented 3 months ago

Thanks @dmytrokoren!