search

jdiazcano / cfg4k

Flexible and easy to use config library written in kotlin
Apache License 2.0
80 stars 6 forks source link

Updated the File Change Reloading Strategy to work with config files in subdirectories #39

Closed slash2314 closed 6 years ago

slash2314 commented 6 years ago

Updated the File Change Reloading Strategy to work with config files in subdirectories. It resolves the event's filename using the parent and compares it to the provided file's absolute path. Added tests to go along with the changes.

jdiazcano commented 6 years ago

Hello @slash2314

First of all you are the first contributor apart from me to the project!! 🍔 xD

Second, travis-ci seems to be broken with pull requests I have opened a bug to them so let's see in the coming days if they answer or not. In the meantime it should be possible to create a new branch, build from there and see that everything works and then I can merge manually to master.

I have taken a look at the code and everything looks good!

jdiazcano commented 6 years ago

Created the branch reload-subdirectories (https://github.com/jdiazcano/cfg4k/tree/reload-subdirectories) and it's ok now on travis. I don't know what is wrong with it :(

I'm merging it manually!