search

jdiegodcp / ramlfications

Python parser for RAML
https://ramlfications.readthedocs.org
Apache License 2.0
234 stars 50 forks source link

Any plans to support Windows? #111

Open pankajghosh-old opened 7 years ago

pankajghosh-old commented 7 years ago

Hi - Are there any future plans to support Windows platform?

econchick commented 7 years ago

Hi @pankajghosh! Not particularly, although I also don't know what breaks on Windows. I also don't have easy access to a Windows VM. I welcome contributions of such, even if it is just letting me know what needs to be addressed.

I'll leave this issue open to see if there is more interest in support for Windows. My apologies, and thank you!

pankajghosh-old commented 7 years ago

Hi @econchick - The project makes some implicit assumptions related to absolute/relative paths which error on Windows. This issue manifests itself mainly in JSON references($ref) not working - both absolute and relative.

Good news is that current unit test coverage seems to catch all these issues(they do fail on Windows server) and I can probably submit a fix for this. If I submit a PR for these fixes, will you accept the changes?

econchick commented 7 years ago

Hey @pankajghosh ! I'm so so sorry I didn't get back to you earlier! I would definitely accept a PR for this!

If you have limited time, then be sure to branch off of the 0.2.0-dev branch (not master) so we can get it into the latest release. If you have a bit more time, then a 2nd PR would be great based off of master (a little confusing, but master is latest release on PyPI).