jdiegodcp / ramlfications

Python parser for RAML
https://ramlfications.readthedocs.org
Apache License 2.0
234 stars 50 forks source link

why markdown2 rather than markdown #119

Open simevo opened 7 years ago

simevo commented 7 years ago

Hi, I'm in the process of packaging this library for Debian (see https://bugs.debian.org/843882).

I noticed that ramlfications depends on markdown2 (https://pypi.python.org/pypi/markdown2, https://github.com/trentm/python-markdown2) rather than markdown (https://pypi.python.org/pypi/Markdown, https://github.com/waylan/Python-Markdown). It turns out that only the latter is packaged in Debian (https://packages.qa.debian.org/p/python-markdown.html). There are three solutions:

  1. I patch ramlfications to depend on markdown only for the purpose of Debian packaging
  2. you change ramlfications to depend on markdown
  3. we package markdown2 in Debian as well (why not if there's a good reason).

ATM I took option 1, it was easy: https://gitlab.com/simevo/python-ramlfications/blob/master/debian/patches/0000-markdown2.diff. The only side-effect is that some tests fail for some silly newlines (which is also easy to patch: https://gitlab.com/simevo/python-ramlfications/blob/master/debian/patches/0001-test_newlines.diff).

Is there any specific reason why you depend on markdown2 rather than markdown?

simevo commented 7 years ago

Bump ?