fixed parsing responses bodies, see spotify/ramlfications#12

[jenner]

• The responses bodies map is now accepting more then just 'application/json' media types. If there's no valid media type, the default one is used and the body spec is inspected for 'schema' and 'example' parameters
• Added XSDs for thingy and thingy-list
• Added parser tests wrt response bodies parsing

[econchick]

Hey @jenner! Thank you so much! I'll review this PR this week; nice catch!

[econchick]

Still reviewing this - but just a couple of things:

1 I would add/update a test in test_parser.py that parser.py returns what you expected. For example, when parsing the response schema/example in lines 515-521, you actually get (for the example) an array (I think? not too familiar with xml/xsd) of thingies, named Foo and Bar. Essentially similar to the JSON example here.

1. The !!null use case isn't tested - mind adding a test for that too?

[jenner]

yep, can do

On Tue, May 26, 2015 at 8:06 PM, Lynn Root notifications@github.com wrote:

Still reviewing this - but just a couple of things:

1 I would add/update a test in test_parser.py that parser.py returns what you expected. For example, when parsing the response schema/example in lines 515-521, you actually get (for the example) an array (I think? not too familiar with xml/xsd) of thingies, named Foo and Bar. Essentially similar to the JSON example here https://github.com/spotify/ramlfications/blob/521b8a00ee2212df34d2999c6ecd2012adf39b3f/tests/test_parser.py#L106 .

1. The !!null use case isn't tested - mind adding a test for that too?

— Reply to this email directly or view it on GitHub https://github.com/spotify/ramlfications/pull/13#issuecomment-105620950.

[econchick]

Merged locally - thank you!

[econchick]

Also FYI will probably upload new release today or tomorrow - cheers!

[econchick]

FYI included in release 0.1.5 and available on PyPI