search

jdiegodcp / ramlfications

Python parser for RAML
https://ramlfications.readthedocs.org
Apache License 2.0
234 stars 50 forks source link

Fix for spotify/ramlfications#85 #88

Closed bpowell65536 closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 97.11%

Branch #88 has no coverage reports uploaded yet.

Powered by Codecov. Updated on successful CI builds.

econchick commented 8 years ago

woah 13 commits! I like a clean commit history (or as clean as possible) :smile: Please rebase/squash into one commit.

bpowell65536 commented 8 years ago

Sorry, will do the squash/rebase. I'm a bit new to this stuff, so it might take me a while to figure out :)

econchick commented 8 years ago

@bpowell65536 here's a good resource that I point people to on rebasing/squashing commits.

econchick commented 8 years ago

@bpowell65536 once you squash everything (FYI it will require a force-push since you essentially re-write history when squashing) and address the little nitpicks, I'll merge this. This looks good, thank you for catching this bug and giving a patch!

bpowell65536 commented 8 years ago

@econchick Thanks! I have squashed everything now and pushed to my remote repository, but I'm not sure how to make the squashed commit appear instead of all the individual ones. Do I need to make a PR for the squashed commit instead?

econchick commented 8 years ago

@bpowell65536 if you appropriately squashed everything, and (force) pushed to the same remote branch as before, then the pull request should automatically update. So I have a feeling it wasn't done correctly.