search

jdiegodcp / ramlfications

Python parser for RAML
https://ramlfications.readthedocs.org
Apache License 2.0
234 stars 49 forks source link

Add Nose to Dev Dependencies #9

Closed benhamill closed 9 years ago

benhamill commented 9 years ago

When I tried getting the tests running locally, I saw lots of explosions about there being no module called 'nose', so I've added it to the development dependencies.

benhamill commented 9 years ago

Now that I've fixed this, though, I'm still getting failures on master. I'll track them down some more and probably add whatever fixes to this PR, if that's cool. So far, I'm just running the 2.7 tests locally, so lemme know if I do something short-sighted due to my only having the one Python version locally (or due to any other reason, really).

benhamill commented 9 years ago

Possibly related: Should running tox -e py27 be rewriting ramlfications/data/supported_mime_types.json?

benhamill commented 9 years ago

I was seeing a lot of stuff like this:

_________________________________________________________________________________________ ERROR collecting env/lib/python2.7/site-packages/tests/test_application.py _________________________________________________________________________________________
env/lib/python2.7/site-packages/tests/test_application.py:18: in <module>
    from util import with_app, raises_msg, TestApp
env/lib/python2.7/site-packages/tests/util.py:29: in <module>
    from nose import tools, SkipTest
E   ImportError: No module named nose

and installing nose made them go away. But I just now uninstalled nose and looked harder at the errors and I'm seeing some really weird stuff that makes me think it's my environment. I'll report back if I find anything interesting, otherwise I'll just close this. Heh.

econchick commented 9 years ago

Hey @benhamill - re: writing to supported_mime_types.json that should be mocked out (adjusting the tests now!) - thanks for that pointer.

I've spun up an Ubuntu box with a setup for the repo (only py 2.7 is installed), and did the following:

git clone git@github.com:spotify/ramlfications.git
cd ramlfications
mkvirtualenv test-raml
(test-raml) pip install -r dev-requirements.txt
(test-raml) tox -e py27

And everything passes (3 skipped tests, 98% cov)

I'm on IRC on Freenode - #ramlfications channel - if you'd like to chat.

benhamill commented 9 years ago

OK, yeah. Something was jacked up in my environment, somehow. I nuked the virtualenv and started from scratch and things are cool. Weird.