search

jdiegodcp / ramlfications

Python parser for RAML
https://ramlfications.readthedocs.org
Apache License 2.0
234 stars 50 forks source link

Fix for repeated application of parameter transforms to parameter values #96

Closed bpowell65536 closed 8 years ago

bpowell65536 commented 8 years ago

When a transformed parameter appears more than once in a single field in a RAML file, the transform is applied each time the transformed parameter appears. This can cause problems with the singularize transform: for example, singularizing 'users' once results in 'user', and then singularizing 'user' results in the non-string value False. This patch fixes this problem by not overwriting the original parameter value with the result of the transformation.

codecov-io commented 8 years ago

Current coverage is 96.93%

Branch #96 has no coverage reports uploaded yet.

Powered by Codecov. Updated on successful CI builds.

econchick commented 8 years ago

I merged this locally after rebasing - great catch!!

bpowell65536 commented 8 years ago

@econchick Thanks! Can I delete this branch now? GitHub is warning me that it hasn't been merged properly...