search

jdillard / sphinx-sitemap

Sphinx extension to generate a multi-lingual, multi-version sitemap for HTML builds
https://sphinx-sitemap.readthedocs.io/en/latest/index.html
MIT License
55 stars 21 forks source link

Error with Sphinx 7.2 #69

Closed kai687 closed 1 year ago

kai687 commented 1 year ago

app.outdir is now a Path, not a string, so line 213 breaks.

kai687 commented 1 year ago

https://github.com/sphinx-doc/sphinx/issues/11608

larsoner commented 1 year ago

Opened https://github.com/jdillard/sphinx-sitemap/pull/70, hopefully it works :crossed_fingers:

jdillard commented 1 year ago

Thanks! I'll have to test it out to make sure it doesn't break for older versions (it doesn't seem to be) and update tox as well now that 7 is out.

larsoner commented 1 year ago

I'll have to test it out to make sure it doesn't break for older versions (it doesn't seem to be) and update tox as well now that 7 is out.

Want me to add that parametrization to continuous_integration.yml? Then you don't have to manually test this...

larsoner commented 1 year ago

... couldn't resist the temptation. Added to #70 but I can revert if needed

jdillard commented 1 year ago

Thanks for pointing that out @kai687 and thanks for the great work in the PR @larsoner!

2.5.1 is out now with the fix: https://github.com/jdillard/sphinx-sitemap/releases/tag/v2.5.1