jdinhify / vscode-theme-gruvbox

Gruvbox theme for vscode based on https://github.com/morhetz/gruvbox
https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox
MIT License
274 stars 63 forks source link

Theme only applies to code edtior (not status bar or background of sidebar/tabs) #11

Closed JonasGruenwald closed 5 years ago

JonasGruenwald commented 5 years ago

Not sure if I'm doing something wrong, but unlike on the screenshots here, the theme only applies to the code editor for me, all other colors stay the default light/dark.

I'm setting the theme with the command 'Preferences: Color Theme', do I need to do something else to have it apply globally?

jdinhify commented 5 years ago

I'm not sure what's wrong, but let's try to look into this.

Do you have any other extension that's affecting the workbench?

Could you show your full settings.json (for both user & workplace) so that I could have a look.

JonasGruenwald commented 5 years ago

Hi, thanks for taking the time to reply!

My user settings.json:

{
    "workbench.activityBar.visible": false,
    "workbench.colorTheme": "Gruvbox Dark (Hard)",
    "window.menuBarVisibility": "toggle",
    "editor.minimap.enabled": false,
}

The workspace settings are empty. I just disabled all other extensions and reloaded, no change.

Maybe I should have mentioned: I'm not using the Microsoft binary release of vscode, I am building from source according to their instructions, I just built it from the master of https://github.com/Microsoft/vscode again to make sure I have the latest version, it says version 1.29.0 in the about menu, do you think that could be the issue?

Here is what it looks like for me: hqscr_2018-10-30_23-43-05_1920x1080 hqscr_2018-10-30_23-43-11_1920x1080

jdinhify commented 5 years ago

from the theme name, maybe you're using a different extension, could you please check if you're using this https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox

my theme menu looks like this with the correct extension (note that there's no round bracket around the contrast)

theme-menu

JonasGruenwald commented 5 years ago

Ohh man I feel stupid now, I had installed the wrong one indeed. Thanks for your work on this extension, looks really good!