search

jdinhify / vscode-theme-gruvbox

Gruvbox theme for vscode based on https://github.com/morhetz/gruvbox
https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox
MIT License
274 stars 63 forks source link

fixed tab bar selectors #14

Closed sedmicha closed 5 years ago

sedmicha commented 5 years ago

I noticed the tab bar background being off, and after going through the extension files I figured it's probably not intentional, but caused by a wrong selector. This is not as visible with the dark variant as it's dark-gray vs the default black, but with the light theme the default white really sticks out. It's even visible in the screenshots that the rightmost portion of the tab bar has wrong color.

jdinhify commented 5 years ago

Thanks for this @sedmicha

I'm not sure if I can notice anything though. If you could get screenshots of before and after the change to show the difference, it'd be great.

sedmicha commented 5 years ago

Here you go. As I mentioned it's not as apparent with the dark variant, but with the light one the white stripe is an eye sore.

Before light-before After light-after Before dark-before After dark-after