search

jdinhify / vscode-theme-gruvbox

Gruvbox theme for vscode based on https://github.com/morhetz/gruvbox
https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox
MIT License
265 stars 63 forks source link

Small adjustments to the workbench elements not covered #18

Open JavierReyes945 opened 5 years ago

JavierReyes945 commented 5 years ago

Hi, thanks for this amazing theme. I have used previously a base16 derivate theme for almost a year now, until last week when I discover this nice color scheme.

I am using dark hard and medium (to differentiate code and insiders), and only wish the theme would cover some workbench elements that still look default (a.k.a. the icons in the top right of an open editor, the top right icons of the problem-output-debug-terminal windows, and the top right icons for the sidebar spaces.

theme icons in workbench

problems bar icons

git menu icons

jdinhify commented 5 years ago

Thanks Javier, it's a good idea. However, from a quick look at the docs and a few tries, I'm not sure if we can change the colour of those icons, especially when new icons are added when new extensions installed.

If you know of a theme that does it, we can use it as a reference to try figuring out how.

JavierReyes945 commented 4 years ago

Apparently VSCode now allow the theming to include those icons (see here). It might be worth to re-open and consider this?

jdinhify commented 4 years ago

Thanks @JavierReyes945 This issue was never closed, it's just blocked since the functionalities weren't there.

I checked and at the point of writing this message, I can only see icon.foreground as an option in the config, not icon.default. I'm happy to unblock this one and use just icon.foreground, but there's a few icons that aren't changed (such as git's refresh & commit icons)

Would you like to contribute to this @JavierReyes945 ?

JavierReyes945 commented 4 years ago

Would you like to contribute to this @JavierReyes945 ?

I can give it a try, for the fun of doing something new... As I am not really trained in JS (I'm an embedded developer), but it should not be that hard to figure it out (what's life without hobbies like editor ricing/theming?).

jdinhify commented 4 years ago

That's awesome, thanks @JavierReyes945 .

Please do let me know if you don't have the time capacity to commit though. I'm more than happy to try and implement this if you're busy and not able to play around.